nixos/nextcloud: add an extraPackages option

[balsoft]

Adds an extraPackages option to easily add packages to nextcloud's PATH.

This is useful to enable video thumbnail generation by adding ffmpeg there.

I feel like we could also add ffmpeg to extraPackages by default as it's quite useful, but maybe there's a reason not to do this.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Shawn8901]

Fyi @SuperSandro2000 : as the nuschtos module for nextcloud does similar things, your might be interested in that

[Ma27]

We do add everything from environment.systemPackages here already.
I'm a little hesitant to change that because of the potential fallout for people, but I'd very much prefer to have one of extraPackages or systemPackages for that.

[Ma27]

Also, the manual build fails.

[drupol]

The manual fails also in my PRs (#370895 (comment)). I don't think the issue is related to this PR.

[Ma27]

       … from call site
         at /home/runner/work/nixpkgs/nixpkgs/nixos/modules/services/web-apps/nextcloud.nix:326:21:
          325|
          326|     extraPackages = mkOption {
             |                     ^
          327|       type = types.listOf types.package;

       error: function 'mkOption' called with unexpected argument 'exampleText'
       at /home/runner/work/nixpkgs/nixpkgs/lib/options.nix:67:5:
           66|   mkOption =
           67|     {
             |     ^
           68|     # Default value used when no definition is given in the configuration.

This looks very much like it's related to this PR.

[drupol]

Oh indeed!!! Oops :s

[balsoft]

We do add everything from environment.systemPackages here already.

Right, but that seems to be a very non-NixOS-y way of doing things. I don't want to have ffmpeg installed on my system ( definitely not by default when installing nextcloud) and yet it would be quite useful to have ffmpeg in nextcloud's PATH.

As for backwards-compatibility, maybe we can warn about for a release or two and then actually switch to extraPackages.

[Ma27]

For the sake of consistency, shouldn't these be added to nextcloud-cron & nextcloud-update-db?
Especially the former may also need things that one would add here.

[Ma27]

What I meant with

but I'd very much prefer to have one of extraPackages or systemPackages for that.

was to either use these paths xor extraPackages for everything.

Given we have an agreement to go for extraPackages, I'd suggest:

• we add a warning to the release notes about the removal of these paths in 25.11 (to the 25.05 release notes)
• remove this section again
• and use extraPackages everywhere, as mentioned above.