-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.beancount: 2.3.6 -> 3.1.0 #371541
base: master
Are you sure you want to change the base?
Conversation
I am not using v3 currently. How is it working with existing tools now? |
I used v3 for the last 6 months, and it works ok for me. However, I don't use any custom importers based on Overall, I think it is in good enough shape for everyday use, but it depends on your setup. |
It would be nice to have v3 in nixpkgs. But since there are major incompatibilities between v2 and v3, and v2 is still widely used, I would like to keep both v2 and v3 in nixpkgs, i.e. |
Ok, makes sense. I reworked PR: added separate package for beancount3 and support for building fava with either version. This way user can specify |
4faf5eb
to
85ca22d
Compare
d4e4b3c
to
4bedca5
Compare
After some thought I really want to drop support for beancount v2 in this PR but not sure which way forward is the best. I understand that there are people who would be inconvenienced by this but feel now is a good moment to od it. Most of the tools from the ecosystem supports beancount v3 and some supports only v3 going forward (see beanprice for example). I see multiple ways forward
In both situation 2 and 3 it should be possible to force version using overlay similar to
and have all other packages use it. However this only works as long as package itself implements support for v2 and v3 (like fava for example). If package drops support for v2 (like beanprice 2.0) it wouldn't work and one would have to have separate beanprice package for beancount v2. This could be achievable but I'm not sure if it worth it. |
I have removed formatting changes to |
Let's do this one for now. We can drop v2 once it fails to build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message needs to be adapted. I suggest
python313Packages.beancount: 2.3.6 -> 3.1.0
python313Packages.beancount_2: init at 2.3.6
It might make sense to set |
Added comment in |
Add package for beancount v3
Add package for
beangulp
as a replacement forbeancount.ingest
Update package for
beanquery
to use snapshot version that using TatSu-LTS dependency: beancount/beanquery#226Update
fava
to version 1.30.1 which supports bothbeancount2
andbeancount3
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.