Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

har-to-k6: init at 0.14.10 #374901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

har-to-k6: init at 0.14.10 #374901

wants to merge 1 commit into from
+39 −0

Conversation

cterence
Copy link
Contributor

@cterence cterence commented Jan 18, 2025 •
edited
Loading

har-to-k6: Converts LI-HAR and HAR to K6 script.

Init at 0.14.10

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5109

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374901

aarch64-darwin

✅ 1 package built:
  • har-to-k6

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2201

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 19, 2025
Defelo
Defelo reviewed Jan 21, 2025
View reviewed changes
@cterence cterence requested a review from Defelo January 27, 2025 21:24
@cterence cterence self-assigned this Jan 27, 2025
@cterence
Copy link
Contributor Author

cterence commented Jan 27, 2025 •
edited
Loading

@Defelo Thank you very much for the suggestions, I added them to the PR.

@cterence cterence changed the title har-to-k6: init at 0.14.8 har-to-k6: init at 0.14.9 Jan 28, 2025
@cterence
Copy link
Contributor Author

Updated to 0.14.9 since new release https://github.com/grafana/har-to-k6/releases/tag/v0.14.9.

@cterence cterence requested a review from Defelo January 28, 2025 11:09
@Defelo
Copy link
Member

Defelo commented Jan 28, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 374901

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13009104542

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-374901-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/c2pykri9vnz6wn5mbgpk4l6dfajqhqix-har-to-k6-0.14.9
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-374901-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/4x71lyaykkra345qmz470l3nb7mallnz-har-to-k6-0.14.9
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-374901-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/flc33q0ln4vnang5qsc397mbxnw8jx58-har-to-k6-0.14.9
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-374901-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/z15nyji6g81dfd73cd8a6xrbvyky4b0r-har-to-k6-0.14.9

x86_64-linux

✅ 1 package built:
  • har-to-k6

aarch64-linux

✅ 1 package built:
  • har-to-k6

x86_64-darwin

✅ 1 package built:
  • har-to-k6

aarch64-darwin

✅ 1 package built:
  • har-to-k6

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 1, 2025
@cterence cterence changed the title har-to-k6: init at 0.14.9 har-to-k6: init at 0.14.10 Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defelo Defelo Defelo approved these changes

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Assignees

@cterence cterence

Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cterence @nixos-discourse @ethancedwards8 @Defelo @wegank