Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fish: add functions setting #377595

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nixos/fish: add functions setting #377595

wants to merge 2 commits into from

Conversation

Rua
Copy link

@Rua Rua commented Jan 28, 2025

Notice: This PR is currently blocked by #377948.

This adds an option programs.fish.functions, to specify user-defined functions that should be available in the system-wide configuration. The code is taken from home-manager, but would also be useful for nixpkgs.

This is my first time contributing to nixpkgs, and still relatively new to Nix stuff. Feedback and guidance would be welcome!

Things done


Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 28, 2025
Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me, though I am no fish expert. It probably could use some tests as well.

@nbraud nbraud requested a review from SigmaSquadron February 21, 2025 15:31
@nbraud
Copy link
Contributor

nbraud commented Feb 21, 2025

@Rua I requested a review from the module's maintainer, and trimmed the PR's checklist down to the relevant items.

@nbraud nbraud added the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: blocked by pr/issue Another PR or issue is preventing this from being completed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants