Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: disable thread_affinity test #378448

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Pleune
Copy link
Contributor

@Pleune Pleune commented Feb 1, 2025

fixes #378438

libuv includes a test which specifically requires thread-affinity to be unset, or else you get an error:
# Assertion failed in test/test-thread-affinity.c on line 73: cpumask[0] && "test must be run with cpu 0 affinity"

I assume that packages should be able to be built regardless of affinity, so this test should not be run.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member

Please don't delete the template.

@SuperSandro2000
Copy link
Member

@ofborg build libuv

@Pleune
Copy link
Contributor Author

Pleune commented Feb 3, 2025

Should I rebase to staging? I'm not sure why label-pr did not mark this as a large rebuild as in #364055. This change does cause most of my system to rebuild.

@rickynils rickynils mentioned this pull request Feb 4, 2025
3 tasks
@SuperSandro2000
Copy link
Member

yes please

@Pleune Pleune closed this Feb 4, 2025
@Pleune Pleune reopened this Feb 4, 2025
@Pleune Pleune force-pushed the libuv-no-thread-afffinity branch from e0e95df to dab4611 Compare February 4, 2025 21:46
@Pleune Pleune changed the base branch from master to staging February 4, 2025 21:47
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 4, 2025
@SuperSandro2000 SuperSandro2000 merged commit 89cfd9a into NixOS:staging Feb 5, 2025
40 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: libuv
2 participants