Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waywall: init at 0-unstable-2025-02-07 #380318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

waywall: init at 0-unstable-2025-02-07 #380318

wants to merge 2 commits into from
+76 −0

Conversation

MonkieeBoi
Copy link

@MonkieeBoi MonkieeBoi commented Feb 8, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 8, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Feb 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 8, 2025
donovanglover
donovanglover reviewed Feb 8, 2025
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs! Please change the PR title and commit message to waywall: init at 0-unstable-2025-02-07

@MonkieeBoi MonkieeBoi changed the title waywall: init at be96e20 waywall: init at 0-unstable-2025-02-07 Feb 8, 2025
@MonkieeBoi
Copy link
Author

Thank you so much for the quick and indepth review

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380318

aarch64-linux

✅ 1 package built:
  • waywall

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 10, 2025
donovanglover
donovanglover reviewed Feb 12, 2025
View reviewed changes
donovanglover
donovanglover previously requested changes Feb 12, 2025
View reviewed changes
@MonkieeBoi
Copy link
Author

Is there any work left for this to get merged?

@donovanglover
Copy link
Member

  1. Would like confirmation that the buildInputs are correct, ideally from a reviewer that regularly uses C.
  2. This package is non-trivial to test due to the setup involved, so any confirmation that it works would help reviewers.

@MonkieeBoi
Copy link
Author

Ah I see, for what its worth the packages builds and the application has been working for me so mostly waiting on a review I guess

@donovanglover
Copy link
Member

Pinging the PrismLauncher maintainers to see if they'd be interested in helping

Scrumplex
Scrumplex requested changes Feb 24, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex requested changes

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

@donovanglover donovanglover donovanglover left review comments

@Minion3665 Minion3665 Awaiting requested review from Minion3665

@getchoo getchoo Awaiting requested review from getchoo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MonkieeBoi @ethancedwards8 @donovanglover @Scrumplex @wegank @NixOSInfra