Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] stp: 2.3.3 -> 2.3.4; fix tests; fix aarch64 compatibility; fix Python bindings; fix Darwin compatibility #382701

Closed
wants to merge 1 commit into from
Closed

[Backport release-24.11] stp: 2.3.3 -> 2.3.4; fix tests; fix aarch64 compatibility; fix Python bindings; fix Darwin compatibility #382701

wants to merge 1 commit into from

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Feb 17, 2025 •
edited
Loading

Manual backport of #348447 because a Python package was added alphabetically directly after stp

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@numinit
stp: 2.3.3 -> 2.3.4
8eedf3f 
Bump the version, enable checkPhase, and create an installCheckPhase.
Turn on Darwin support (it works) and fix the Python libs.

Use cadical by default, though support `useCadical = false` in an
override if users want to disable it.

(cherry picked from commit 8f31d53)
@numinit numinit changed the base branch from master to release-24.11 February 17, 2025 00:36
@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: python and removed 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Feb 17, 2025
@nix-owners nix-owners bot requested a review from natsukium February 17, 2025 00:37
@numinit numinit closed this Feb 17, 2025
@numinit numinit deleted the backport-348447-to-release-24.11 branch February 17, 2025 00:39
@numinit numinit restored the backport-348447-to-release-24.11 branch February 17, 2025 00:39
@numinit numinit deleted the backport-348447-to-release-24.11 branch February 17, 2025 00:39
@numinit numinit restored the backport-348447-to-release-24.11 branch February 17, 2025 00:39
@numinit numinit mentioned this pull request Feb 17, 2025
Open
13 tasks
@nix-owners nix-owners bot requested a review from McSinyx February 17, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@McSinyx McSinyx Awaiting requested review from McSinyx

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@numinit