Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx5-mcbopomofo: enable strictDeps #382760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fcitx5-mcbopomofo: enable strictDeps #382760

wants to merge 1 commit into from

Conversation

Shiphan
Copy link
Contributor

@Shiphan Shiphan commented Feb 17, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Shiphan Shiphan closed this Feb 17, 2025
@Shiphan Shiphan reopened this Feb 17, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 17, 2025
@Vonfry
Copy link
Member

Vonfry commented Feb 17, 2025

I update this package as well #382800 with fcitx5 togather and fix the build.

@Shiphan
Copy link
Contributor Author

Shiphan commented Feb 17, 2025

I think it's preferred to enable strictDeps (#370256, #178468)

@Shiphan Shiphan marked this pull request as draft February 18, 2025 01:16
@Vonfry
Copy link
Member

Vonfry commented Feb 18, 2025

My pr has been merged already. You cloud rebase this onto master and readd strictDeps and fix the building.

@Shiphan Shiphan changed the title fcitx5-mcbopomofo: fix build fcitx5-mcbopomofo: enable strictDeps Feb 18, 2025
@Shiphan Shiphan marked this pull request as ready for review February 18, 2025 07:38
Vonfry
Vonfry approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@Vonfry Vonfry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM.

@Vonfry Vonfry added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vonfry Vonfry Vonfry approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shiphan @Vonfry