-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.whisperx: init at 3.3.1 #383191
Draft
bengsparks
wants to merge
1
commit into
NixOS:master
Choose a base branch
from
bengsparks:whisperx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sample-with-srt.mp4 |
bengsparks
commented
Feb 18, 2025
dd353ef
to
5ee1f1f
Compare
f5d7c66
to
171f90f
Compare
Moraxyc
reviewed
Feb 19, 2025
(there was no "cuda-users" or "torch-cuda" group, so if cuda-maintainers is inappropriate for this, feel free to ignore :) |
nixpkgs/pkgs/development/libraries/ctranslate2/default.nix Lines 10 to 11 in 73cf49b
We may need to override ctranslate2 to enable cuda support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372412.
This package has only been run on aarch64-darwin, and without GPU support. I have attached example output generated using the built package.
I would be very grateful for reviewers who are capable for providing other platforms, especially GPU access!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.