Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.whisperx: init at 3.3.1 #383191

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bengsparks
Copy link

@bengsparks bengsparks commented Feb 18, 2025

Closes #372412.

This package has only been run on aarch64-darwin, and without GPU support. I have attached example output generated using the built package.
I would be very grateful for reviewers who are capable for providing other platforms, especially GPU access!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bengsparks
Copy link
Author

sample-with-srt.mp4

@niklaskorz
Copy link
Contributor

(there was no "cuda-users" or "torch-cuda" group, so if cuda-maintainers is inappropriate for this, feel free to ignore :)

@Moraxyc
Copy link
Contributor

Moraxyc commented Feb 19, 2025

withCUDA ? false,
withCuDNN ? false,

We may need to override ctranslate2 to enable cuda support.

@bengsparks bengsparks marked this pull request as draft February 20, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: whisperX
4 participants