Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefly-iii: 6.2.6 -> 6.2.9, firefly-iii-data-importer: 1.6.0 -> 1.6.1 #383245

Merged
merged 2 commits into from
Feb 24, 2025
Merged

firefly-iii: 6.2.6 -> 6.2.9, firefly-iii-data-importer: 1.6.0 -> 1.6.1 #383245

merged 2 commits into from
Feb 24, 2025

Conversation

savyajha
Copy link
Contributor

@savyajha savyajha commented Feb 19, 2025 •
edited
Loading

firefly-iii: firefly-iii/firefly-iii@v6.2.6...v6.2.9
firefly-iii-data-importer: firefly-iii/data-importer@v1.6.0...v1.6.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@savyajha savyajha added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 6.topic: php backport release-24.11 Backport PR automatically labels Feb 19, 2025
@nix-owners nix-owners bot requested a review from PatrickDaG February 19, 2025 04:50
@savyajha savyajha changed the title Firefly iii firefly-iii: 6.2.6 -> 6.2.7, firefly-iii-data-importer: 1.6.0 -> 1.6.1 Feb 19, 2025
@savyajha savyajha added 8.has: package (update) This PR updates a package to a newer version 6.topic: php labels Feb 19, 2025
@PatrickDaG
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383245

x86_64-linux

✅ 2 packages built:
  • firefly-iii
  • firefly-iii-data-importer

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 20, 2025
@savyajha savyajha changed the title firefly-iii: 6.2.6 -> 6.2.7, firefly-iii-data-importer: 1.6.0 -> 1.6.1 firefly-iii: 6.2.6 -> 6.2.9, firefly-iii-data-importer: 1.6.0 -> 1.6.1 Feb 24, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383245

x86_64-linux

❌ 1 package failed to build:
  • firefly-iii
✅ 1 package built:
  • firefly-iii-data-importer

aarch64-linux

❌ 1 package failed to build:
  • firefly-iii
✅ 1 package built:
  • firefly-iii-data-importer

x86_64-darwin

✅ 1 package built:
  • firefly-iii-data-importer

aarch64-darwin

✅ 1 package built:
  • firefly-iii-data-importer

@savyajha
Copy link
Contributor Author

@GaetanLepage Sorry, pushed the wrong commit by mistake earlier. Have fixed it now.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383245

x86_64-linux

✅ 2 packages built:
  • firefly-iii
  • firefly-iii-data-importer

aarch64-linux

✅ 2 packages built:
  • firefly-iii
  • firefly-iii-data-importer

x86_64-darwin

✅ 1 package built:
  • firefly-iii-data-importer

aarch64-darwin

✅ 1 package built:
  • firefly-iii-data-importer

GaetanLepage
GaetanLepage approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@GaetanLepage GaetanLepage merged commit 7ae34ea into NixOS:master Feb 24, 2025
24 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 24, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 24, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@PatrickDaG PatrickDaG PatrickDaG approved these changes

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savyajha @PatrickDaG @GaetanLepage @wegank