nixos/syncthing: define and handle encryptionPassword option #383442
+245
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the syncthing config update script to embed secrets into the json request. Specifically, we handle the `encryptionPassword` secret. With this code, the user can embed path to the encrpyption password for a given device the folder is shared with, and have it loaded in, without touching the nix store.
- Change `folder.devices` type into `oneOf [(listOf str) (attrsOf
(submodule { ... }))]`.
- Expose `encryptionPassord` within the attrSet of the devices option.
This allows the user to set the encrpyption password use to share the
folder's data with. We do this by file path, as opposed to string
literal, because we do not want to embed the encrpyption password into
the nix store.
github-actions
bot
added
6.topic: nixos
jfly
force-pushed
the
syncthing_encryption_password
branch
from
2041ad3 to
c5f68f3
Compare
8 tasks
github-actions
bot
added
10.rebuild-darwin: 0
a-kenji
reviewed
Feb 19, 2025
jfly
force-pushed
the
syncthing_encryption_password
branch
2 times, most recently
from
a64c44e to
3e527dd
Compare
jfly
force-pushed
the
syncthing_encryption_password
branch
from
3e527dd to
ab1b412
Compare
github-actions
bot
added
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
10.rebuild-darwin: 0
a-kenji
reviewed
Feb 20, 2025
a-kenji
approved these changes
Feb 20, 2025
wegank
added
the
12.approvals: 1
jfly
force-pushed
the
syncthing_encryption_password
branch
from
ab1b412 to
5c19dbd
Compare
wegank
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to @h33p for the PR this was based on: #342138.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.