-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test.testers.testEqualArrayOrMap: switch to testBuildFailure' #383516
Draft
ConnorBaker
wants to merge
14
commits into
NixOS:master
Choose a base branch
from
ConnorBaker:feat/testEqualArrayOrMap-uses-testBuildFailurePrime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
test.testers.testEqualArrayOrMap: switch to testBuildFailure' #383516
ConnorBaker
wants to merge
14
commits into
NixOS:master
from
ConnorBaker:feat/testEqualArrayOrMap-uses-testBuildFailurePrime
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ad08906
to
18bd102
Compare
00f18e2
to
07a29fd
Compare
07a29fd
to
552e612
Compare
…upScript argument to script
552e612
to
3dc48d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: testing
Tooling for automated testing of packages and modules
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a stacked PR. The following PRs must be merged before this PR:
Rewrites the tests for
testers.testEqualArrayOrMap
so they usetesters.testBuildFailure'
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.