Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.testers.testEqualArrayOrMap: switch to testBuildFailure' #383516

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ConnorBaker
Copy link
Contributor

Important

This is a stacked PR. The following PRs must be merged before this PR:

Rewrites the tests for testers.testEqualArrayOrMap so they use testers.testBuildFailure'.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ConnorBaker ConnorBaker self-assigned this Feb 20, 2025
@github-actions github-actions bot added 6.topic: testing Tooling for automated testing of packages and modules 8.has: documentation This PR adds or changes documentation labels Feb 20, 2025
@ConnorBaker ConnorBaker changed the title Feat/test equal array or map uses test build failure prime test.testers.testEqualArrayOrMap: switch to testBuildFailure' Feb 20, 2025
@ConnorBaker ConnorBaker force-pushed the feat/testEqualArrayOrMap-uses-testBuildFailurePrime branch from ad08906 to 18bd102 Compare February 20, 2025 01:27
@ConnorBaker ConnorBaker force-pushed the feat/testEqualArrayOrMap-uses-testBuildFailurePrime branch 3 times, most recently from 00f18e2 to 07a29fd Compare February 21, 2025 18:29
@ConnorBaker ConnorBaker force-pushed the feat/testEqualArrayOrMap-uses-testBuildFailurePrime branch from 07a29fd to 552e612 Compare February 21, 2025 18:33
@ConnorBaker ConnorBaker force-pushed the feat/testEqualArrayOrMap-uses-testBuildFailurePrime branch from 552e612 to 3dc48d1 Compare February 21, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: testing Tooling for automated testing of packages and modules 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant