Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hplip: use Python 3.12 #383681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

raboof
Copy link
Member

@raboof raboof commented Feb 20, 2025

Fixes #383676

Marked 'draft' since I have not tested this with a real printer yet. I do have access to one, I just need to find a minute to do a proper test.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 20, 2025
Fixes NixOS#383676

Apparently distutils is now needed for the configure script to find
the reference to the Python header files
@raboof raboof force-pushed the hplip-use-python312 branch from ef72175 to 04e5046 Compare February 20, 2025 15:42
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 20, 2025
Copy link
Contributor

@Yarny0 Yarny0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested hplipWithPlugin on x86-64 with a HP LaserJet 1000 printer, after cherry-picking onto a recent nixos-unstable: Package builds fine, NixOS loads firmware into printer as soon as printer is connected via USB, prints beautiful test page.

@raboof
Copy link
Member Author

raboof commented Feb 24, 2025

now confirmed it works fine for me as well 👍

@raboof raboof marked this pull request as ready for review February 24, 2025 12:27
@nix-owners nix-owners bot requested a review from ttuegel February 24, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hplip: stuck on Python 3.11
2 participants