add new tool find_dc to nixpkgs #384374
Draft
add new tool find_dc to nixpkgs #384374
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding find_dc tool build using go to help pentesters find dc in pentest
drupol
requested changes
Feb 23, 2025
There was a problem hiding this comment.
Hello,
Thanks for your PR. I set it to draft until all the issues are fixed, this will help also other maintainers.
On top of the things I commented in the file, the commit log message needs to be correctly formatted (hint: look at how other commits).
The PR title needs to be adjusted too (hint: look at other PRs)
Let me know if you need some assistance.
| src = pkgs.fetchFromGitHub { | ||
| owner = "0xthefr34k"; | ||
| repo = "find_dc"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| tag = "v${version}"; |
| hash = "sha256-rPw0H2jlCyeAKGLCR1Gvisv+hHCCmyRWi1k+i5zzxTg="; | ||
| }; | ||
|
|
||
| vendorHash = null; |
| @@ -0,0 +1,24 @@ | |||
| { pkgs, lib }: | |||
There was a problem hiding this comment.
Suggested change
| { pkgs, lib }: | |
| { lib, buildGoModule }: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.