Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freetube: 0.23.1 -> 0.23.2 #384596

Merged
merged 2 commits into from
Feb 24, 2025
Merged

freetube: 0.23.1 -> 0.23.2 #384596

merged 2 commits into from
Feb 24, 2025
+8 −3

Conversation

ddogfoodd
Copy link
Contributor

@ddogfoodd ddogfoodd commented Feb 23, 2025 •
edited
Loading

Changelog: https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.23.2-beta
Diff: FreeTubeApp/FreeTube@v0.23.1-beta...v0.23.2-beta

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@matteo-pacini matteo-pacini added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 23, 2025
@matteo-pacini
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384596

x86_64-darwin

❌ 1 package failed to build:
  • freetube

aarch64-darwin

❌ 1 package failed to build:
  • freetube

Does not build on Darwin - the name of output app is "Electron.app" for some reason, and the derivation is looking for "FreeTube.app"

SigmaSquadron
SigmaSquadron approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to leave this broken on Darwin for a bit, actually. Freetube 0.23.1 doesn't work on any architecture, so the way I see it, this update makes it work on at least 50% of available architectures instead of 0%.

@SigmaSquadron SigmaSquadron added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 24, 2025
@ryand56
Copy link
Member

ryand56 commented Feb 24, 2025

Can this be marked as broken on Darwin for the time being?

@eljamm eljamm added the backport release-24.11 Backport PR automatically label Feb 24, 2025
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 24, 2025
@ddogfoodd ddogfoodd mentioned this pull request Feb 24, 2025
Closed
13 tasks
@alyaeanyx
Copy link
Member

Other than that, I can confirm that this update works on Linux. The 403 error upon video playback has been resolved too.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Feb 24, 2025
@sfrique
Copy link

sfrique commented Feb 24, 2025

I can also confirm it builds on Linux and the 403 error was gone for me as well.
used this: nix run 'nixpkgs#nixpkgs-review' pr 384596

@Gliczy Gliczy mentioned this pull request Feb 24, 2025
Closed
3 tasks
@eljamm eljamm added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Feb 24, 2025
@Atemu Atemu merged commit 337a22d into NixOS:master Feb 24, 2025
27 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 24, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 24, 2025
Open
1 task
@ddogfoodd ddogfoodd deleted the update-freetube branch February 24, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfrique sfrique sfrique approved these changes

@alyaeanyx alyaeanyx alyaeanyx approved these changes

@eljamm eljamm eljamm approved these changes

@ryand56 ryand56 Awaiting requested review from ryand56

@ryneeverett ryneeverett Awaiting requested review from ryneeverett

@starsep starsep Awaiting requested review from starsep

@SigmaSquadron SigmaSquadron Awaiting requested review from SigmaSquadron

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ddogfoodd @matteo-pacini @ryand56 @alyaeanyx @sfrique @starsep @eljamm @SigmaSquadron @wegank @Atemu