Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/h2o: TLS recommendations #384730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Feb 24, 2025

From Mozilla’s ssl-config-generator project… adds cipher suites & HSTS header. It should be as easy as services.h2o.tlsRecommendations = "modern".

Before anyone asks: I am not interested at this time in pulling out these Mozilla recommendations into some abstraction other modules could use.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 24, 2025
@toastal toastal force-pushed the h2o-module-tls-recs branch 2 times, most recently from a2ca346 to 802d97b Compare February 24, 2025 10:30
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 24, 2025
@toastal toastal force-pushed the h2o-module-tls-recs branch from 802d97b to a6f18f4 Compare February 24, 2025 10:39
@toastal
Copy link
Contributor Author

toastal commented Feb 24, 2025

$ nix-build --show-trace -A nixosTests.h2o
/nix/store/fajbvrr5fh80rcac46lrzsfsj8n30fcs-vm-test-run-h2o-basic
/nix/store/blscj03iybbc5mxkzpzdfag2rnxw7bdz-vm-test-run-h2o-mruby
/nix/store/chyap92zhhhdxyrfbhvadx8pk7wmfzgi-vm-test-run-h2o-tls-recommendations

@toastal toastal force-pushed the h2o-module-tls-recs branch 7 times, most recently from 85cf0c8 to f9dcdec Compare February 24, 2025 15:00
From Mozilla’s ssl-config-generator project
@toastal toastal force-pushed the h2o-module-tls-recs branch from f9dcdec to 908645d Compare February 24, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant