Skip to content

Conversation

@dawnofmidnight
Copy link
Contributor

@dawnofmidnight dawnofmidnight commented Oct 8, 2025

Update to 1.13.0. relnotes: https://github.com/grpc/grpc-node/releases/tag/grpc-tool%401.13.0

Fix the build for CMake 4 (tracking issue: #445447). Though it is mildly concerning that upstream is using a vendored four-year-old version of protobuf, the fix here is the same one they applied. See grpc/grpc-node#3013.

maintainer ping: @nzhang-zh (though it looks like the maintainer has been inactive on github for some years now)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from nzhang-zh October 8, 2025 14:38
@CodedNil CodedNil mentioned this pull request Oct 8, 2025
13 tasks
@dawnofmidnight dawnofmidnight force-pushed the grpc-tools-cmake4-update branch from 411af5e to 7a49b21 Compare October 8, 2025 15:41
@pyrox0
Copy link
Member

pyrox0 commented Oct 9, 2025

LGTM, also note that you don't have to ping maintainers, since our auto-review bot does that for you nowadays! No harm no foul though.

@pyrox0 pyrox0 added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit 6d8ab35 Oct 9, 2025
25 of 29 checks passed
@dawnofmidnight dawnofmidnight deleted the grpc-tools-cmake4-update branch October 9, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants