Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix predict with multiple models #290

Merged
merged 4 commits into from
Jan 2, 2024
Merged

fix predict with multiple models #290

merged 4 commits into from
Jan 2, 2024

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Jan 2, 2024

Description

#255 introduced a bug where the original series values weren't backed up correctly, so when using multiple models the first model would get the correct values but the second one would get the predictions from the first one instead of the original values and so on.

Fixes #289

Checklist:

  • This PR has a meaningful title and a clear description.
  • The tests pass.
  • All linting tasks pass.
  • The notebooks are clean.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez added the fix label Jan 2, 2024
@jmoralez jmoralez merged commit beae503 into main Jan 2, 2024
16 checks passed
@jmoralez jmoralez deleted the fix-predict branch January 2, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core]Using multiple models can cause new_x lag feature shift
1 participant