Fixes #26335: Port RestApiAccount api endpoint to zio-json #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
arch_26335/port_restapiaccount_api_endpoint_to_zio_json
branch
from
45f1299 to
8260a11
Compare
fanf
commented
Feb 14, 2025
| @@ -72,10 +72,10 @@ class RestApiAccounts( | |||
|
|
|||
| // used in ApiAccounts snippet to get the context path | |||
| // of that service | |||
| val relativePath: List[String] = "secure" :: "apiaccounts" :: Nil | |||
There was a problem hiding this comment.
this file need to be deleted once we have checked the different use cases
fanf
commented
Feb 14, 2025
| @@ -1766,68 +1765,6 @@ object RudderConfigInit { | |||
| ) | |||
| } | |||
|
|
|||
| lazy val directiveApiService14 = { | |||
There was a problem hiding this comment.
we need to move them inline to avoid dreaded Platform restriction: a parameter list's length cannot exceed 254.
fanf
commented
Feb 14, 2025
| @@ -58,7 +60,7 @@ object DateFormaterService { | |||
| ZonedDateTime.ofInstant(java.time.Instant.ofEpochMilli(d.getMillis), ZoneId.of(d.getZone.getID, ZoneId.SHORT_IDS)) | |||
| } | |||
|
|
|||
| object json { | |||
| trait DateTimeCodecs { | |||
There was a problem hiding this comment.
make it a trait to ease composition with other codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/26335
WIP status at 2025-02-14
RestApiAccountsmust be deleted (butI did clean-up things related to the old format)On the backend side, the most notable change are that we have different data structures for different action and return values.
In particular:
ClearTextSecretand theApiToken(hashed).