Sonarr list endpoints #835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return apiError(http.StatusBadRequest, "decoding payload", err) | ||
| } | ||
|
|
||
| ilist.ID, _ = strconv.ParseInt(mux.Vars(req)["ilid"], mnd.Base10, mnd.Bits64) |
There was a problem hiding this comment.
You could read the ID from the payload instead of require it in the param. Lemme know if you want to change that.
There was a problem hiding this comment.
This was copied from one of the other existing apps so it would need to be changed on more than just this one
There was a problem hiding this comment.
I resolved the other 2, this one i'll let you take care of :)
|
sigh i rebased on all the new stuff and now it is all attached to this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the endpoints to the client for import lists. The starr library looks like it already has everything
TODO