Skip to content

[Evals] Replace 'getargspec with getfullargspec` to support python 3.12#102

Merged
SumanthRH merged 4 commits intomainfrom
sumanthrh/python312
Mar 25, 2025
Merged

[Evals] Replace 'getargspec with getfullargspec` to support python 3.12#102
SumanthRH merged 4 commits intomainfrom
sumanthrh/python312

Conversation

@SumanthRH
Copy link
Member

@SumanthRH SumanthRH commented Mar 24, 2025

What does this PR do?

Adds compatibility for python 3.12.

TODO:

  • Verify backwards compatibility with python 3.10

Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
@SumanthRH SumanthRH marked this pull request as ready for review March 24, 2025 23:17
Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
@SumanthRH SumanthRH requested a review from erictang000 March 24, 2025 23:41
@SumanthRH SumanthRH merged commit 10081a6 into main Mar 25, 2025
2 checks passed
yllkryeziu pushed a commit to yllkryeziu/adaptive-compute-rewrite that referenced this pull request Dec 12, 2025
lru0612 pushed a commit to lru0612/SkyThought that referenced this pull request Feb 24, 2026
# What does this PR do?

FIrst PR in enabling GPU CI. 

This PR adds a `SkyRL-GPU` workflow that will run GPU CI on Anyscale. We
will basic unit and integration tests running on a 4xL4 instance in this
workflow. Currently, the CI will run post-merge on `main` . For pull
requests, it requires manual trigger by a maintainer. (so it should not
run on every commit even for maintainers, since that can be wasteful).


In this PR, I've only ported over one of our existing gpu tests -
`test_models.py` to run on CI . The plan is to gradually add more and
more tests after we've made them more efficient and compatible to be run
on a 4xL4 node.

---------

Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants