Skip to content

Conversation

zedtux
Copy link

@zedtux zedtux commented Nov 8, 2023

No description provided.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NullVoxPopuli
Copy link
Owner

Hi @zedtux ! thanks for the PR! can you add information about this to the README as well? thanks!

@zedtux
Copy link
Author

zedtux commented Nov 10, 2023

Done sir!

@zedtux
Copy link
Author

zedtux commented Nov 14, 2023

Any news please?


The available hooks to tie in to are:
- `disconnected {}`
- `disconnected { |code, reason| }`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been a while for me, but where would someone find out what possible codes and reasons could be passed here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea! The last one I had was reason being AuthError, I don't remember the code.

I guess you can find it from the ActionCable protocol specification, but Is that important for this PR?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, thanks! It's just been ages since I've worked with Rails' things

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NullVoxPopuli
Copy link
Owner

it seems CI isn't set up on this repo 😅 would you be willing to PR a GH action workflow that sets that up?
Travis no longer does anything, but this was the config used: https://github.com/NullVoxPopuli/action_cable_client/blob/master/.travis.yml

@zedtux
Copy link
Author

zedtux commented Nov 16, 2023

I'm not sure I can create a PR with that and get it running on your repo, is there any kind of permissions for that?

@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Nov 16, 2023

We'll find out! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants