Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
apps/repl
(limber)TODO:
await import()
Adds perf-check.sh, and I have these results atm:
rolldown-vite
Vite
Before customizing the optimizeDeps config, these were my results
The subsequent reloads due to lazy depOptimization for the default path were silly.
Webpack (
f2760ff
)modified perf-check.sh for the embroider-webpack app
See: ember-no-cache
This is from about 9 months ago, before I converted the main app in this repo to Vite.
This can't be a direct comparison, because there the codebase is just so different now.
In particular, the REPL now supports multiple frameworks and 9 months ago it only supported Ember -- and this compounds with codemirror as well.
See: ember-no-cache
Of note, the app at this time had about 10x fewer network requests than what is on main today.
On main today, most speed gains will probably be realized via reducing the number of network requests.