convert yaml to nbt #37

cyilin · 2017-12-15T12:26:27Z

No description provided.

Librazy · 2017-12-15T12:53:34Z

src/main/java/cat/nyaa/HamsterEcoHelper/utils/database/tables/TempStorageRepo_v2.java

+import java.util.UUID;
+
+@DataTable("temporary_storage_v2")
+public class TempStorageRepo_v2 {


We may use some more descriptive name like TempNbtStorageRepo

Or use something like NbtTempStorageRepo, other than append v2 should be better.

RecursiveG · 2017-12-15T18:07:52Z

src/main/java/cat/nyaa/HamsterEcoHelper/utils/database/tables/MarketItem_v2.java

+        this.amount = (long) amount;
+    }
+
+    @DataColumn("unit_price")


NC Database should be able to process Double correctly.
No need to use getter/setter.

RecursiveG

As long as NC database can process the java types correctly, we don't need those getter/setter.
Just set the fields as public.

RecursiveG · 2017-12-15T18:25:34Z

Before merging this commit, I want to first deal with the TempStorage seperately. see Move TemporaryStorageRepository to NyaaCore #35
In any case, having a lot of _v2 classes is unacceptable.

convert yaml to nbt

6ec0f63

cyilin requested review from Librazy and RecursiveG December 15, 2017 12:26

Librazy reviewed Dec 15, 2017

View reviewed changes

Librazy approved these changes Dec 15, 2017

View reviewed changes

RecursiveG reviewed Dec 15, 2017

View reviewed changes

RecursiveG suggested changes Dec 15, 2017

View reviewed changes

cyilin added 2 commits December 16, 2017 09:43

revert change

e3d1e1c

remove setter/getter & rename

f0f843a

cyilin closed this Feb 26, 2018

Provide feedback