Skip to content

main: copy schema-publish script & workflow from dev #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ralfhandl
Copy link
Contributor

New schema iterations are published directly from the corresponding vX.Y-dev branches.

Copying the updated scripts to main to prevent accidental loss.

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl added Housekeeping script Pull requests that update Bash or JavaScript code labels Mar 1, 2025
@ralfhandl ralfhandl requested review from a team as code owners March 1, 2025 15:20
@ralfhandl ralfhandl moved this to In Progress in Automation & Infrastructure Mar 1, 2025
@lornajane
Copy link
Contributor

Do we need these files on main? I thought the point was that the things needed only for dev could stay there and on on the version-specific branches?

@ralfhandl
Copy link
Contributor Author

Eventually dev flows to v3.1-dev from which v3.1.2-rel branches off and flows back into main.

This PR just speeds up that flow and prevents script changes on main to interfere with what needs to be on the dev branches.

For the future I propose that scripts are always changed on main and then flow on so that we do not disturb our own circles.

It also helps my tests of how to produce a release branch if there are fewer "noise" differences.

@ralfhandl
Copy link
Contributor Author

A more urgent and compelling reason: the current workflow on main publishes schemas from the schemas folder, whereas we now want to publish schemas from the src folder on a vX.Y-dev branch, and the v3.1-dev schema is already ahead of its main counterpart.

We do not want to accidentally publish schemas again from main, and merging this PR prevents that.

@duncanbeevers
Copy link
Contributor

👎 I don't think these workflow files and scripts should live on main.

I think we should move ahead with #4356 which will similarly prevent accidental publishing from main, but without copying these support files.

@ralfhandl ralfhandl closed this Mar 8, 2025
@ralfhandl ralfhandl deleted the main-copy-schema-publish-from-dev branch March 8, 2025 07:17
@duncanbeevers duncanbeevers mentioned this pull request Mar 25, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping script Pull requests that update Bash or JavaScript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants