Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] l10n_it_fatturapa_in: forward port of #3475 #3716

Closed
wants to merge 5 commits into from
Closed

[16.0] l10n_it_fatturapa_in: forward port of #3475 #3716

wants to merge 5 commits into from

Conversation

are-agilebg
Copy link
Contributor

@are-agilebg are-agilebg commented Nov 14, 2023 •
edited
Loading

Forward port of #3475.

@are-agilebg are-agilebg force-pushed the 16.0-forward-3475 branch 2 times, most recently from 417a2d4 to d9be84c Compare November 14, 2023 09:47
@francesco-ooops
Copy link
Contributor

risolve #2699 per la 16 giusto?

@are-agilebg
Copy link
Contributor Author

risolve #2699 per la 16 giusto?

devo essere onesto, non mi è chiaro, vedo che la 2699 viene citata nella 3475 da cui sono partito ma non sono sicuro: mi manca sicuramente del contesto. Probabilmente altri sapranno risponderti con più precisione.

are-agilebg
are-agilebg commented Nov 14, 2023
View reviewed changes
l10n_it_fatturapa_in/views/account_view.xml
@@ -45,7 +53,7 @@
attrs="{'invisible': [('invoices_number', '!=', 0), ('xml_supplier_id', '!=', False), ('invoices_date', '!=', False), ('linked_invoice_id_xml', '!=', False)]}"
/>
</div>
<field name="name" invisible="1" />
<field name="name" />
Copy link
Contributor Author

@are-agilebg are-agilebg Nov 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove 'invisible="1"' otherwise a lot of tests would fail because of "can't write on invisible field name".
The error is raised from https://github.com/odoo/odoo/blob/bde8ac75055d9fb53fb8b989a01f3e865afdfb27/odoo/tests/form.py#L330 which prevents writing invisible/readonly fields to make tests consistent with web UI.
The setting of the name field is performed by fatturapa_common.py create_attachment() method.

@are-agilebg are-agilebg marked this pull request as ready for review November 15, 2023 08:07
@tafaRU
Copy link
Member

tafaRU commented Nov 15, 2023

@are-agilebg fai rebase o preferisci che faccia io? In modo da includere #3718

@are-agilebg
Copy link
Contributor Author

@are-agilebg fai rebase o preferisci che faccia io? In modo da includere #3718

fatto 👍

@tafaRU
Copy link
Member

tafaRU commented Nov 16, 2023

@are-agilebg pre-commit è ancora 🔴 per via di https://github.com/OCA/l10n-italy/actions/runs/6880609018/job/18715191105?pr=3716#step:7:116 Puoi correggere? Grazie.

@francesco-ooops francesco-ooops mentioned this pull request Dec 19, 2023
Merged
@francesco-ooops
Copy link
Contributor

@eLBati scegli te se mergiare questa o chiuderla in favore di #3785 :)

@francesco-ooops francesco-ooops linked an issue Dec 19, 2023 that may be closed by this pull request
[12.0][l10n_it_fatturapa_in] errore su _compute_xml_data #2699
Closed
4 tasks
@eLBati
Copy link
Member

eLBati commented Dec 20, 2023

Chiuderei questa in favore di #3785 perchè ci sono delle modifiche strutturali che sarebbe meglio considerare tutte insieme e che in questa #3716 vengono affrontante penso parzialmente, ad esempio 9834aa2

@francesco-ooops
Copy link
Contributor

@are-agilebg ok per te chiudere?

@TheMule71 TheMule71 mentioned this pull request Nov 15, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelerusti michelerusti michelerusti approved these changes

Assignees
No one assigned
Labels
16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[12.0][l10n_it_fatturapa_in] errore su _compute_xml_data
7 participants
@are-agilebg @francesco-ooops @tafaRU @eLBati @michelerusti @SirTakobi @TheMule71