Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] l10n_it_fatturapa_in - Gruppi IVA #3810

Open
wants to merge 5 commits into
base: 16.0
Choose a base branch
from
Open

[FIX] l10n_it_fatturapa_in - Gruppi IVA #3810

wants to merge 5 commits into from

Conversation

SirAionTech
Copy link
Contributor

@SirAionTech SirAionTech commented Jan 4, 2024 •
edited
Loading

Risolve #1667 per 16.0.
Risolve #3146 per 16.0.

Sostituisce #3513 per risolvere #3513 (review).

Forward port di #3100.
Ho dovuto cambiare qualcosa durante il porting, soprattutto nell'ultimo commit, perché dopo #2750 non viene più sollevata un'eccezione quando vengono trovati partner duplicati.

Dipende da:

@francesco-ooops francesco-ooops mentioned this pull request Jan 4, 2024
Open
5 tasks
@francesco-ooops francesco-ooops linked an issue Jan 4, 2024 that may be closed by this pull request
Gruppi IVA #1667
Open
5 tasks
@francesco-ooops francesco-ooops mentioned this pull request Jan 4, 2024
Open
3 tasks
@francesco-ooops francesco-ooops linked an issue Jan 4, 2024 that may be closed by this pull request
Importazione fattura elettronica con terzo intermediario in Gruppo IVA #3146
Open
3 tasks
@SirAionTech

This comment was marked as resolved.

Sign in to view
@SirAionTech SirAionTech marked this pull request as ready for review January 4, 2024 13:56
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from c34d69a to dc72f06 Compare January 26, 2024 10:26
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from dc72f06 to fa95da5 Compare March 1, 2024 15:36
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from fa95da5 to 639eecc Compare April 19, 2024 13:33
@SirAionTech SirAionTech marked this pull request as draft April 19, 2024 14:29
@SirAionTech SirAionTech marked this pull request as ready for review April 22, 2024 09:05
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 499df25 to 639eecc Compare May 31, 2024 07:25
@SirAionTech SirAionTech marked this pull request as draft May 31, 2024 07:54
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 639eecc to acb7371 Compare May 31, 2024 08:00
@SirAionTech SirAionTech mentioned this pull request May 31, 2024
Closed
@SirAionTech SirAionTech marked this pull request as ready for review May 31, 2024 09:54
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch 3 times, most recently from cb98726 to 4d74656 Compare May 31, 2024 09:58
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 4d74656 to 6934f6d Compare August 6, 2024 11:06
@SirAionTech SirAionTech marked this pull request as draft August 6, 2024 12:04
@SirAionTech SirAionTech force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from 6934f6d to f3c7e04 Compare August 6, 2024 13:27
@SirAionTech SirAionTech marked this pull request as ready for review August 6, 2024 13:53
@francesco-ooops
Copy link
Contributor

@SirAionTech qualche indicazione per test funzionali?

@SirAionTech
Copy link
Contributor Author

@SirAionTech qualche indicazione per test funzionali?

Sono nelle issue linkate in descrizione

Risolve #1667 per 16.0.
Risolve #3146 per 16.0.

@SirAionTech SirAionTech added the is porting This pull request is porting a change from another version label Nov 11, 2024
@SirAionTech
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from f3c7e04 to b67afbf Compare November 12, 2024 09:33
@SirAionTech
Copy link
Contributor Author

@matteoopenf @eLBati magari vi interessa visto che avete revisionato #3100?

@matteoopenf
Copy link
Contributor

@matteoopenf @eLBati magari vi interessa visto che avete revisionato #3100?

si mi interessa ci arrivo

@patrickt-oforce
Copy link
Contributor

@SirAionTech riesci a fare un rebase per riavviare runbot?

@francesco-ooops
Copy link
Contributor

/ocabot rebase

SirTakobi and others added 5 commits January 31, 2025 17:36
@SirTakobi @SirAionTech @OCA-git-bot
[COV] l10n_it_fatturapa_in: Error when there are multiple partners
01c4b8c 
Co-authored-by: SirAionTech <[email protected]>
@SirTakobi @SirAionTech @OCA-git-bot
[REF] l10n_it_fatturapa_in: Include partners in error message
f7c268a 
Extract commercial partner retrieval
Extract partner search
Use the actual domain from multi-company partners sharing rule

Co-authored-by: SirAionTech <[email protected]>
@SirTakobi @SirAionTech @OCA-git-bot
[FIX] l10n_it_fatturapa_in: Manage VAT groups
7fc349e 
Co-authored-by: SirAionTech <[email protected]>
@SirTakobi @SirAionTech @OCA-git-bot
[IMP] l10n_it_fatturapa_in: Skip Duplicated Partners for some fields
8caac9a 
Only CedentePrestatore and CessionarioCommittente are checked for VAT Groups,
when other partner fields match multiple partners just log an inconsistency

Co-authored-by: SirAionTech <[email protected]>
@SirAionTech @OCA-git-bot
[COV] l10n_it_fatturapa_in: Do not depend on previous tests
c53559a
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-fix-l10n_it_fatturapa_in-vat_group branch from b67afbf to c53559a Compare January 31, 2025 17:37
@patrickt-oforce
Copy link
Contributor

Test funzionale effettuato su runbot con file contenente un partner di un gruppo IVA correttamente importato e il partner viene correttamente riconosciuto

@matteoopenf
Copy link
Contributor

matteoopenf commented Feb 14, 2025 •
edited
Loading

se entra vediamo per fare il back port a 14 e chiudiamo quella inizialmente aperta da noi

@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers buona per il merge?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteoopenf matteoopenf matteoopenf approved these changes

@patrickt-oforce patrickt-oforce patrickt-oforce approved these changes

Assignees
No one assigned
Labels
approved is porting This pull request is porting a change from another version ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importazione fattura elettronica con terzo intermediario in Gruppo IVA Gruppi IVA
6 participants
@SirAionTech @francesco-ooops @OCA-git-bot @matteoopenf @patrickt-oforce @SirTakobi