Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW] l10n_it_delivery_note: multipli fw-ports e il loro adattamento #4008

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

PicchiSeba
Copy link
Contributor

@PicchiSeba PicchiSeba commented Mar 1, 2024

Fw-port di diversi commit per l10n_it_delivery_note necessari per l'aggiornamernto alla 16.0 di #3938

Rispettivamente corrispondono alle seguenti PR:

Sono consapevole che ci siano molti cambiamenti in una sola PR, se lo ritenete necessario posso fare ogni porting in una PR a sé stante, chiaramente ci vorrà più tempo

@PicchiSeba PicchiSeba marked this pull request as ready for review March 1, 2024 12:16
@OCA-git-bot
Copy link
Contributor

Hi @MarcoCalcagni, @renda-dev, @aleuffre,
some modules you are maintaining are being modified, check this out!

@PicchiSeba PicchiSeba marked this pull request as draft March 1, 2024 12:16
@PicchiSeba
Copy link
Contributor Author

Lascio in Bozza perchè non sono ancora riuscito a provarla

@PicchiSeba PicchiSeba force-pushed the 16.0-fw-port-3936 branch 4 times, most recently from a95b866 to 5ec6031 Compare March 7, 2024 15:25
@PicchiSeba
Copy link
Contributor Author

Il fallimento dei test non mi sembra collegato ai cambiamenti che ho fatto in questa PR. Sembra più un problema relativo al numero di sessioni che possono venire aperte contemporaneamente

@PicchiSeba PicchiSeba marked this pull request as ready for review March 7, 2024 16:21
@PicchiSeba
Copy link
Contributor Author

2024-03-07 15:34:32,123 485 WARNING odoo odoo.addons.currency_rate_update.models.res_currency_rate_provider: Currency Rate Provider "Bank of Italy" failed to obtain data since 2023-03-07 until 2024-03-07
Traceback (most recent call last):
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 699, in urlopen
httplib_response = self._make_request(
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 445, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 440, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.10/http/client.py", line 1375, in getresponse
response.begin()
File "/usr/lib/python3.10/http/client.py", line 318, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.10/http/client.py", line 287, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/opt/odoo-venv/lib/python3.10/site-packages/requests/adapters.py", line 439, in send
resp = conn.urlopen(
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 755, in urlopen
retries = retries.increment(
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/util/retry.py", line 532, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/packages/six.py", line 769, in reraise
raise value.with_traceback(tb)
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 699, in urlopen
httplib_response = self._make_request(
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 445, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "/opt/odoo-venv/lib/python3.10/site-packages/urllib3/connectionpool.py", line 440, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.10/http/client.py", line 1375, in getresponse
response.begin()
File "/usr/lib/python3.10/http/client.py", line 318, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.10/http/client.py", line 287, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/opt/odoo-venv/lib/python3.10/site-packages/odoo/addons/currency_rate_update/models/res_currency_rate_provider.py", line 132, in _update
data = provider._obtain_rates(
File "/__w/l10n-italy/l10n-italy/currency_rate_update_boi/models/res_currency_rate_provider_BOI.py", line 275, in _obtain_rates
response = requests.get(
File "/opt/odoo-venv/lib/python3.10/site-packages/requests/api.py", line 76, in get
return request('get', url, params=params, **kwargs)
File "/opt/odoo-venv/lib/python3.10/site-packages/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/opt/odoo-venv/lib/python3.10/site-packages/requests/sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "/opt/odoo-venv/lib/python3.10/site-packages/requests/sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "/opt/odoo-venv/lib/python3.10/site-packages/requests/adapters.py", line 498, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
2024-03-07 15:34:32,142 485 INFO odoo odoo.addons.currency_rate_update_boi.tests.test_currency_rate_update_boi: ======================================================================
2024-03-07 15:34:32,142 485 ERROR odoo odoo.addons.currency_rate_update_boi.tests.test_currency_rate_update_boi: FAIL: TestCurrencyRateUpdate.test_foreign_base_currency
Traceback (most recent call last):
File "/__w/l10n-italy/l10n-italy/currency_rate_update_boi/tests/test_currency_rate_update_boi.py", line 157, in test_foreign_base_currency
self.test_update_BOI_year()
File "/__w/l10n-italy/l10n-italy/currency_rate_update_boi/tests/test_currency_rate_update_boi.py", line 95, in test_update_BOI_year
self.assertTrue(rates)
AssertionError: res.currency.rate() is not true

@PicchiSeba PicchiSeba force-pushed the 16.0-fw-port-3936 branch 2 times, most recently from 486fe0e to 96ee467 Compare March 8, 2024 07:26
@PicchiSeba PicchiSeba changed the title [FW] l10n_it_delivery_note: various fw-ports and their adaptation [FW] l10n_it_delivery_note: multipli fw-ports e il loro adattamento Mar 8, 2024
@francesco-ooops francesco-ooops linked an issue Mar 8, 2024 that may be closed by this pull request
2 tasks
@francesco-ooops francesco-ooops linked an issue Mar 8, 2024 that may be closed by this pull request
2 tasks
@francesco-ooops francesco-ooops linked an issue Mar 8, 2024 that may be closed by this pull request
3 tasks
@francesco-ooops francesco-ooops linked an issue Mar 8, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@aleuffre
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Sorry @aleuffre you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@francesco-ooops
Copy link
Contributor

@tafaRU puoi provvedere tu?

@aleuffre
Copy link
Contributor

No, c'è un file di troppo, pandoc, da rimuovere.

@aleuffre aleuffre force-pushed the 16.0-fw-port-3936 branch 2 times, most recently from 5107f27 to c4af74b Compare March 19, 2024 16:48
@aleuffre aleuffre force-pushed the 16.0-fw-port-3936 branch from c4af74b to 1a324e1 Compare March 19, 2024 16:49
@aleuffre
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-4008-by-aleuffre-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8e43fca into OCA:16.0 Mar 19, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f208d0c. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 16.0-fw-port-3936 branch March 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment