Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Registrazione contabile per cespite crea sempre rettifica negativa #4249

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[FIX] Registrazione contabile per cespite crea sempre rettifica negativa #4249

merged 1 commit into from
Jul 9, 2024

Conversation

SirAionTech
Copy link
Contributor

Risolve #4017 per 16.0.

Forward port di #4018.

@SirAionTech
[FIX] l10n_it_asset_management: Update asset with entry
4d37b8e 
Deciding the depreciation type based on the move type does not work with entries because they could be either "in" or "out".
Everything depends on the sign of the account move lines amount: if it is positive then it is an "in" depreciation, otherwise "out".
@SirAionTech SirAionTech mentioned this pull request Jul 2, 2024
Closed
2 tasks
@francesco-ooops francesco-ooops linked an issue Jul 2, 2024 that may be closed by this pull request
Registrazione contabile per cespite crea sempre rettifica negativa #4017
Closed
2 tasks
@SirAionTech SirAionTech marked this pull request as ready for review July 3, 2024 07:14
@MaurizioConte
Copy link

@SirAionTech @francesco-ooops TEST positivo sia per rettifica positiva che per rettifica negativa l'unica cosa è che se non si inserisce il partner sulla riga della registrazione contabile non fa collegare il cespite.

@francesco-ooops
Copy link
Contributor

@MaurizioConte segui questa guida per fare la review: https://www.odoo-italia.org/documentazione/14.0/sviluppo/review.html#revisione

@MaurizioConte
Copy link

@SirAionTech @francesco-ooops
I test sono OK

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jul 8, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SirAionTech
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-4249-by-SirAionTech-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 9, 2024
@OCA-git-bot
Merge PR #4249 into 16.0
da356fc 
Signed-off-by SirAionTech
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-4249-by-SirAionTech-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 45f6bc3 into OCA:16.0 Jul 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1a49ad5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaurizioConte MaurizioConte MaurizioConte approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Registrazione contabile per cespite crea sempre rettifica negativa
5 participants
@SirAionTech @MaurizioConte @francesco-ooops @OCA-git-bot @MaurizioPellegrinet