[16.0] [FIX] l10n_it_withholding_tax: amount_net_pay_residual calculated incorrectly due to the mixed use of fields #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly due to the mixed use of fields Conditions: Invoice posted in USD currency for a company with the main currency in EUR. Invoice is partially reconciled in USD, one invoice line reconciled with 2 journal items: - one journal items is exchange rates differences - another item is partial payment Basically, amount_net_pay_residual is calculated by taking USD amount and subtracting EUR amount, which leads to inconsistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditions: Invoice posted in USD currency for a company with the main currency in EUR. Invoice is partially reconciled in USD, one invoice line reconciled with 2 journal items:
Basically, amount_net_pay_residual is calculated by taking USD amount and subtracting EUR amount, which leads to inconsistency