[16.0] Add module l10n_ch_credit_control_dunning_fees_qr_report #737
Conversation
| invoices = self.env["account.move"].browse(docids) | ||
| for invoice in invoices: | ||
| if invoice.id not in dunning_fees_qr_amounts: | ||
| continue |
There was a problem hiding this comment.
| invoices = self.env["account.move"].browse(docids) | |
| for invoice in invoices: | |
| if invoice.id not in dunning_fees_qr_amounts: | |
| continue | |
| invoices = self.env["account.move"].browse(list(dunning_fees_qr_amounts.keys())) | |
| for invoice in invoices: |
You know already the ones to browse no?
| if self.id in qr_dunning_fees_amounts: | ||
| return "{:,.2f}".format(qr_dunning_fees_amounts[self.id]).replace( | ||
| ",", "\xa0" | ||
| ) | ||
| else: | ||
| return "{:,.2f}".format(self.amount_residual).replace(",", "\xa0") |
There was a problem hiding this comment.
| if self.id in qr_dunning_fees_amounts: | |
| return "{:,.2f}".format(qr_dunning_fees_amounts[self.id]).replace( | |
| ",", "\xa0" | |
| ) | |
| else: | |
| return "{:,.2f}".format(self.amount_residual).replace(",", "\xa0") | |
| if self.id in qr_dunning_fees_amounts: | |
| return "{:,.2f}".format(qr_dunning_fees_amounts[self.id]).replace( | |
| ",", "\xa0" | |
| ) | |
| return "{:,.2f}".format(self.amount_residual).replace(",", "\xa0") |
any comment to explain why this is needed?
l10n_ch_credit_control_dunning_fees_qr_report/models/credit_control_communication_report.py
Outdated
Show resolved
Hide resolved
| report_ref, data, res_ids=res_ids | ||
| ) | ||
|
|
||
| collected_streams = OrderedDict() |
There was a problem hiding this comment.
maybe move to a separate method like _pdf_prepare_streams_cc_dunning_fees?
|
@simahawk Out of moving class to its dedicated file, I would prefer keeping code as it to avoid any unforeseen issue since it's been working in production for a while. Also I'm not the original author, most of the code was from @ajaniszewska-dev , so I cannot necessarily answer all these questions. A test would be good yes. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
3 participants
This module will ensure dunning fees are considered when generating swiss
QR-bill from credit control lines.