Skip to content

Conversation

@michelerusti
Copy link

No description provided.

@michelerusti michelerusti force-pushed the 16.0-add-module-currency_rate_update_fta branch 2 times, most recently from 760ead2 to d52f5b2 Compare February 10, 2025 11:26
@michelerusti michelerusti marked this pull request as ready for review February 10, 2025 11:48
Copy link

@stevech091 stevech091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test OK

@ecino
Copy link

ecino commented Feb 18, 2025

@michelerusti Thanks for your contribution! Can you add some tests to your module to please?

@michelerusti michelerusti force-pushed the 16.0-add-module-currency_rate_update_fta branch 6 times, most recently from ddd0561 to 31a4ebc Compare June 20, 2025 14:47
@michelerusti michelerusti force-pushed the 16.0-add-module-currency_rate_update_fta branch 4 times, most recently from 0e46db6 to f3006a5 Compare July 11, 2025 15:35
@michelerusti
Copy link
Author

@michelerusti Thanks for your contribution! Can you add some tests to your module to please?

Hi, can you take a look at this PR please?

"installable": True,
"application": False,
"auto_install": False,
"price": 10.00,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, removed. Thanks!

@michelerusti michelerusti force-pushed the 16.0-add-module-currency_rate_update_fta branch from f3006a5 to 7853211 Compare August 29, 2025 13:56
Copy link
Member

@jguenat jguenat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello !

Thank you for this module, I tested it but encounter two issues.
The first one is you have to define _get_supported_currencies() in the provider otherwise you cannot choose any currency in the configuration of the provider.

The other is that I had to inverse the rate to get correct result. The https://www.rates.bazg.admin.ch/ is returning SELL rates (inverse_company_rate in Odoo).

You can see it in this commit

Feel free to cherry pick it or copy/paste it. I fetched the supported currencies live but it might be better to have a hard coded list? (it's what other providers do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants