-
-
Notifications
You must be signed in to change notification settings - Fork 165
[ADD] currency_rate_update_fta: Currency Rate Update: Federal Tax Administration #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
[ADD] currency_rate_update_fta: Currency Rate Update: Federal Tax Administration #750
Conversation
760ead2 to
d52f5b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Test OK
|
@michelerusti Thanks for your contribution! Can you add some tests to your module to please? |
ddd0561 to
31a4ebc
Compare
0e46db6 to
f3006a5
Compare
Hi, can you take a look at this PR please? |
| "installable": True, | ||
| "application": False, | ||
| "auto_install": False, | ||
| "price": 10.00, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, removed. Thanks!
f3006a5 to
7853211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello !
Thank you for this module, I tested it but encounter two issues.
The first one is you have to define _get_supported_currencies() in the provider otherwise you cannot choose any currency in the configuration of the provider.
The other is that I had to inverse the rate to get correct result. The https://www.rates.bazg.admin.ch/ is returning SELL rates (inverse_company_rate in Odoo).
You can see it in this commit
Feel free to cherry pick it or copy/paste it. I fetched the supported currencies live but it might be better to have a hard coded list? (it's what other providers do)
No description provided.