Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] mis_builder_analytic: Migration to 16.0 #49

Merged
merged 20 commits into from
Jan 8, 2025

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Apr 24, 2024

Module migrated to version 16.0

cc https://github.com/APSL 154419
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

@peluko00 peluko00 mentioned this pull request Apr 24, 2024
3 tasks
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working correctly, checked in runboat

Copy link
Member

@douglascstd douglascstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[FUNCTIONAL REVIEW]

Thank you for migrating this module. It will be useful for everyone.

The selection by filters does not appear, even with the option selected
image
image

TEST
Bill:
image

Mis Builder Report:
image

Dropdown the value:
image

Investigation v14 and v16:
image
image
image

@peluko00
Copy link
Contributor Author

peluko00 commented May 2, 2024

[FUNCTIONAL REVIEW]

Thank you for migrating this module. It will be useful for everyone.

The selection by filters does not appear, even with the option selected image image

TEST Bill: image

Mis Builder Report: image

Dropdown the value: image

Investigation v14 and v16: image image image

This changes not affected to this module, review again please

@hitrosol
Copy link

runboat is not working...

@peluko00 peluko00 force-pushed the 16.0-mig-mis_builder_analytic branch from 718ecd2 to d72fc38 Compare August 15, 2024 06:34
@peluko00
Copy link
Contributor Author

runboat is not working...

Done!

@hitrosol
Copy link

Thanks for this migration.

It seems the module mis_builder in runboat is not updated, therefore the missing fields as @douglascstd said still not there.
I tried this on my local with the updated mis_builder and the missing fields are shown.

I have comments about this migration as following:

  1. If we use MIS Account Analytic Line as Move Lines Source, then the value in Filter box search view is missing:
Screen Shot 2024-08-15 at 16 04 03

Any plan to update that record so the user can filter the using analytic line in the report view ?

  1. Since v16 the analytic line is not easily grab from account.move.line, therefore it's time to support this module so we can make make dynamic report base on the account_analytic. I suggest to use analytic_account as basis of KPI expression. So whenever user put kpi, example: bale[], therefore it will refer to analytic_account not account. Then, the Auto Expand also can be refer to analytic_account as well. I'm hoping this feature can be adopted in the core of MIS Builder, if not, having this here will be okay as well.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 15, 2024
@sbidoul
Copy link
Member

sbidoul commented Jan 8, 2025

/ocabot migration mis_builder_analytic

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 8, 2025
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Compared with v14.

@hitrosol regarding your remarks:

  1. (missing search view on the mis.account.analytic.line model) this would be a nice addition, but not blocking for the migration, IMO.
  2. (use analytic_account as basis of KPI expression) that would be another module with a different view. I think this has been attempted in previous versions.

@vdewulf
Copy link

vdewulf commented Jan 8, 2025

Hello @peluko00, thanks for migrating this module in v16.
I was looking for a way to create a MIS report with accounting lines and analytic account lines in order to control the split of costs/revenues on various subventions and projects for my customers (for my second job as an accountant). This module matches perfectly our needs.

Here is my functional review based on tests with runboat (thanks @sbidoul for making it possible today).

  1. I created a customer invoice with 2 analytic accounts on one accounting line, splitting the revenues into 20% and 80%.
    Sélection_296

  2. The corresponding analytic items are shown like this:
    Sélection_297

  3. I created a report in MIS Report menu, using a basic template (test, that only show the balance of the account 40000). I activated the comparison mode and added 3 columns: 1 with the source from accounting lines, 1 with the alternative sources from analytic lines with the filter on analytic account "Asustek" and the last with the alternative sources from analytic lines with the filter on analytic account "CamptoCamp":
    Sélection_298
    Details on the config:
    Sélection_299

  4. Result of the report shows the values from the analytic lines.
    Sélection_300

  5. In a further step I can then easily compare the total on the account 40000 and the total of each analytic account, and make sure there is no dubble assignation of the same invoice on different analytic accounts (important in the context of reporting to subventions bodies for example) or that I didn't miss the encoding of an analytic account on an invoice.
    Sélection_301

This is working as I expect it. I didn't check the widgets options and other filters though.

@sbidoul
Copy link
Member

sbidoul commented Jan 8, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-49-by-sbidoul-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1b1e912. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit d41873f into OCA:16.0 Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.