-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] mis_builder_analytic: Migration to 16.0 #49
Conversation
…ount and add analytic_account_id
Currently translated at 13.3% (2 of 15 strings) Translation: mis-builder-contrib-14.0/mis-builder-contrib-14.0-mis_builder_analytic Translate-URL: https://translation.odoo-community.org/projects/mis-builder-contrib-14-0/mis-builder-contrib-14-0-mis_builder_analytic/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working correctly, checked in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runboat is not working... |
718ecd2
to
d72fc38
Compare
Done! |
Thanks for this migration. It seems the module mis_builder in runboat is not updated, therefore the missing fields as @douglascstd said still not there. I have comments about this migration as following:
![]() Any plan to update that record so the user can filter the using analytic line in the report view ?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
/ocabot migration mis_builder_analytic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Compared with v14.
@hitrosol regarding your remarks:
- (missing search view on the
mis.account.analytic.line
model) this would be a nice addition, but not blocking for the migration, IMO. - (use analytic_account as basis of KPI expression) that would be another module with a different view. I think this has been attempted in previous versions.
Hello @peluko00, thanks for migrating this module in v16. Here is my functional review based on tests with runboat (thanks @sbidoul for making it possible today).
This is working as I expect it. I didn't check the widgets options and other filters though. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 1b1e912. Thanks a lot for contributing to OCA. ❤️ |
Module migrated to version 16.0
cc https://github.com/APSL 154419
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review