Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] allow multi-company MIS budgets by account #589

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Nov 23, 2023

When doing multi-company consolidation with MIS Builder we may want to also display the corresponding budget.

It can therefore be desirable to create a MIS budget by account that applies to multiple companies.

It turns out that making the company_id field required for MIS Budgets by Accounts is overly restrictive, and that the really important thing is that the company_id on budget items matches the company of the account of the item.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@github-actions github-actions bot closed this Apr 28, 2024
@sbidoul sbidoul reopened this Apr 29, 2024
@sbidoul sbidoul added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Apr 29, 2024
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbidoul
Copy link
Member Author

sbidoul commented Oct 1, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-589-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d187f7 into OCA:16.0 Oct 1, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9f25d81. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-multi-company-budget branch October 5, 2024 13:29
@sbidoul sbidoul removed the Needs PORT label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16.0 merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants