Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push .pot changes without GitHub secret #290

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 3, 2025

This is a bit more verbose, but avoid the maintenance of a secret token.

Leaving as draft for now.

@sbidoul sbidoul force-pushed the push-pot-without-pat branch from fd1c2e0 to 08bb46e Compare January 3, 2025 14:40
{%- endraw %}
run: |
oca_export_and_commit_pot
git format-patch --stdout --keep-subject @{u}..@ > po.patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The click-odoo-makepot command creates a distinct commit for each addon where pot files have been updated. So by using a patch, we export this list of commits to pass it to the job that will push them to the repo.

@sbidoul sbidoul force-pushed the push-pot-without-pat branch 7 times, most recently from e5f9524 to 63eb3f9 Compare January 4, 2025 14:01
@sbidoul sbidoul marked this pull request as ready for review January 4, 2025 14:04
Use a short lived token to push to the repository.
Don't expose the token to the test jobs.
@sbidoul sbidoul force-pushed the push-pot-without-pat branch from 63eb3f9 to ac40f08 Compare January 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant