Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FW] queue_job: multiple ports from 14.0 #736

Closed

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Jan 13, 2025

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sebalix sebalix marked this pull request as ready for review January 13, 2025 10:47
@florentx
Copy link
Contributor

florentx commented Jan 13, 2025

Hello @sebalix

I'm surprised you open this PR without considering this one first:

Even if it does not use oca-port, I believe it is more complete, since I tried to be exhaustive for all the missing parts.

@sebalix
Copy link
Contributor Author

sebalix commented Jan 13, 2025

@florentx it was not on purpose, sorry, I didn't check first if there was an existing PR!
Yours is more complete because it ports commits of multiple modules at a time indeed.

EDIT: I spotted two commits squashed into one, which is creating false-positive to detect afterwards what is missing, didn't checked the rest.
The goal of oca-port is not to only ease the developer life, but to provide reports so we know what to focus on with hundreds of OCA modules to maintain/migrate among different projects.

@sebalix sebalix closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants