-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_picking_report_undelivered_product: Migration to 18.0 #367
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] stock_picking_report_undelivered_product: Migration to 18.0 #367
Conversation
… undelivered products in delivery slip report
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_picking_report_undelivered_product Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_picking_report_undelivered_product/
Currently translated at 100.0% (19 of 19 strings) Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_picking_report_undelivered_product Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_picking_report_undelivered_product/es/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @juancarlosonate-tecnativa !!!
Minor fix!!
stock_picking_report_undelivered_product/views/report_deliveryslip.xml
Outdated
Show resolved
Hide resolved
Review tests!! |
/ocabot migration stock_picking_report_undelivered_product |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @sergio-teruel. Don't replace views
20cdb90
to
7975c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@rousseldenis @sergio-teruel check again please! |
|
||
<xpath expr="//span[@t-field='bo_line.product_uom_qty']/.." position="after"> | ||
<td class="text-center w-auto"> | ||
<span t-esc="bo_line.product_uom_qty - bo_line.quantity">3.00</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 3.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upsss I see... it's in original view...
Do you know that you can user attribute 'move' to move xml elements??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know it exists, @CarlosRoca13 mentioned it to me, but i don't know how to use it. Can you give me some more details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check again
7975c6f
to
a9c6a97
Compare
class StockMove(models.Model): | ||
_inherit = "stock.move" | ||
|
||
splitted_stock_move_orig_id = fields.Many2one( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juancarlosonate-tecnativa Do we lose the information on existing databases ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this information is no longer useful and will never be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this change needs to be analysed in more depth.
Since odoo base in the delivery slip report already generates a table for undelivered products, i try to reuse as much as possible to avoid code duplication. Retrieve all the stock moves based on the applied filter and set them accordingly. Then, perform a small operation to calculate the actual undelivered quantities: bo_line.product_uom_qty - bo_line.quantity
@Tecnativa TT54343
@CarlosRoca13 @sergio-teruel can you check? thanks!