Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-kernel-oot: build in B with Devtool #1814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dchvs
Copy link
Contributor

@dchvs dchvs commented Jan 17, 2025

Enable external builds, such as those initiated by Devtools, to utilize the B directory for building instead of modifying the source code directory. This prevents the source code from being tainted by build artifacts, which currently results in issues like the following:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        hwpm/drivers/tegra/hwpm/.Module.symvers.cmd
        hwpm/drivers/tegra/hwpm/.modules.order.cmd
        hwpm/drivers/tegra/hwpm/.nvhwpm.ko.cmd
        hwpm/drivers/tegra/hwpm/.nvhwpm.mod.cmd
        hwpm/drivers/tegra/hwpm/.nvhwpm.mod.o.cmd
        hwpm/drivers/tegra/hwpm/.nvhwpm.o.cmd
        hwpm/drivers/tegra/hwpm/Module.symvers
        hwpm/drivers/tegra/hwpm/common/.allowlist.o.cmd
        hwpm/drivers/tegra/hwpm/common/.aperture.o.cmd
        hwpm/drivers/tegra/hwpm/common/.init.o.cmd
        hwpm/drivers/tegra/hwpm/common/.ip.o.cmd
        hwpm/drivers/tegra/hwpm/common/.resource.o.cmd
        hwpm/drivers/tegra/hwpm/common/allowlist.o
        hwpm/drivers/tegra/hwpm/common/aperture.o

@madisongh
Copy link
Member

Does this actually produce the correct results? There are many makefiles and scripts in that tree, and when I put together the recipe I wasn't 100% sure that they would work properly with B != S. The build might not fail, but you could end up with non-functioning drivers. It would have been hard to verify correctness so I didn't think it was worth the risk. One can always use -f on the devtool finish command to work around the in-tree generated files.

@dchvs
Copy link
Contributor Author

dchvs commented Jan 22, 2025

Let me know if you'd like me to proceed with some verifications, or if you'd prefer not to merge this change for now —in that case feel free close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants