Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools module functionality #2389

Merged
merged 21 commits into from
Feb 25, 2025
Merged

Tools module functionality #2389

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9cfb5dd
ATL-9: Tools Module
jcnamendiOdysseus Nov 29, 2023
6af3313
date time update
jcnamendiOdysseus Jan 4, 2024
9a5c4b5
Update Tools module
jcnamendiOdysseus Jan 8, 2024
4f8044b
Address null exception in case of disabled security
jcnamendiOdysseus Jan 31, 2024
e2499b2
- adding permissions to sec_permission, sec_role_permission (migratio…
alex-odysseus Mar 6, 2024
024384b
Remove validation from the Tool class.
jcnamendiOdysseus Mar 7, 2024
36555aa
Remove validation from the Tool class.
jcnamendiOdysseus Mar 7, 2024
3bb1bfe
Add tool permission
jcnamendiOdysseus Apr 3, 2024
498b4c9
add tools messages i18n
jcnamendiOdysseus Apr 11, 2024
132c1c7
Fixed deleting a record would delete the role
jcnamendiOdysseus Apr 18, 2024
389fac5
Remove unused imports
jcnamendiOdysseus Apr 18, 2024
a49ceab
Check if the delete permission for tools is present to add it back.
jcnamendiOdysseus May 6, 2024
88b51dd
Oracle and Microsoft SQL migrations should be no longer supported
alex-odysseus Aug 30, 2024
2cfa1a1
Removing unused translations
alex-odysseus Aug 30, 2024
5acc126
Fixed issue where non-administrator tool editor was unable to save en…
oleg-odysseus Oct 25, 2024
a6d5274
Allowed reading non-enabled tools by a user having 'tool:post && tool…
oleg-odysseus Nov 1, 2024
1e36b5c
Combining migration scripts into one, removing redundant classes, min…
alex-odysseus Dec 17, 2024
4fd6380
ToolRepository method name changes after property renaming in Tool
alex-odysseus Dec 17, 2024
fdf2d79
Aligning with the permissions notation from the migration script
alex-odysseus Jan 8, 2025
ad014ab
Removing malformed entries from the permission schema correcting a mi…
alex-odysseus Feb 17, 2025
616d369
Merge remote-tracking branch 'remotes/origin/master' into tools-module
chrisknoll Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/ohdsi/webapi/security/model/ToolPermissionSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
public class ToolPermissionSchema extends EntityPermissionSchema {
private static Map<String, String> writePermissions = new HashMap<String, String>() {{
put("tool:%s:delete", "Delete Tool with id = %s");
put("tool:%s:put", "Update Tool with id = %s");
put("tool:%s:post", "Create Tool with id = %s");
put("tool:put", "Update a Tool");
put("tool:post", "Create a Tool");
Copy link
Collaborator

@chrisknoll chrisknoll Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work: what will happen is that when the Tool asset is deleted, all these permissions will be deleted and everyone will lose the ability to create and update a tool.

This is an example of the complication of the permission implementation we have in webapi that we'll want to resolve in 3.x or 4.x.

For details on how the non-entity specific permissions caused issues, you can refer to this issue: #2412.

Essentially, the only permissions that go into PermissionSchema are those with entity-id context. The general ones can't be there because deleting one asset will delete the entire (non-asset specific) set of permissions from everyone.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-odysseus , please provide update to this issue.

}};
private static Map<String, String> readPermissions = new HashMap<String, String>() {
{
Expand Down
Loading