Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clearml logger #526

Merged
merged 6 commits into from
Apr 13, 2024
Merged

Add clearml logger #526

merged 6 commits into from
Apr 13, 2024

Conversation

Fissium
Copy link
Contributor

@Fissium Fissium commented Apr 11, 2024

Enhanced the experiment tracking functionality by integrating ClearML

AlekseySh
AlekseySh requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@AlekseySh AlekseySh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I will take a deeper look later

Fissium added 2 commits April 11, 2024 20:43
@Fissium
Fix inheritance hierarchy
92dc94c 
- ClearMLLogger is now a child of Logger
- ClearMLPipelineLogger is a child of ClearMLLogger and IPipelineLogger
@Fissium
Add ClearML logger test to existing pipeline
af8a0ca 
Changes made:
- Deleted 'train_with_clearml.yaml' and 'train_with_clearml.py'
- Replaced TensorBoard with ClearML in 'train_arcface_with_categories.yaml'
AlekseySh
AlekseySh requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@AlekseySh AlekseySh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a few comments

@AlekseySh AlekseySh linked an issue Apr 11, 2024 that may be closed by this pull request
Add ClearML logger #515
Closed
@Fissium
Copy link
Contributor Author

Fissium commented Apr 13, 2024

It seems we need to add clearml to LIBS_TO_IGNORE = ["torch_xla", "pytorch_grad_cam", "wandb", "neptune", "IPython"] in test_import.py.

Am I right?

@AlekseySh
Copy link
Contributor

@Fissium seems like this, yes

AlekseySh
AlekseySh approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@AlekseySh AlekseySh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@AlekseySh AlekseySh merged commit 937be74 into OML-Team:main Apr 13, 2024
8 checks passed
@Fissium Fissium deleted the clearml_logger branch April 13, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseySh AlekseySh AlekseySh approved these changes

Assignees

@Fissium Fissium

Labels
None yet
Projects
OML-planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ClearML logger
2 participants
@Fissium @AlekseySh