Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking datasets #541

Merged
merged 10 commits into from
Apr 20, 2024
Merged

Reworking datasets #541

merged 10 commits into from
Apr 20, 2024

Conversation

AlekseySh
Copy link
Contributor

@AlekseySh AlekseySh commented Apr 19, 2024

# We will remove using keys in __getitem__ for:
# Passing extra information (like categories or sequence id) -> we will use .extra_data instead
# Modality related info (like bboxes or paths) -> they may only exist as internals of the datasets
# is_query_key, is_gallery_key -> get_query_ids() and get_gallery_ids() methods
# Before this, we temporary keep both approaches to make migration easier
  • Introduced slightly different interfaces for datasets
  • Made a dedicated folder for images datasets. Renamed and moved old datasets. Kept names of the old dataset for backward compatibility.
  • Removed ListDataset and its' tests
  • tests: DummyQGDataset -> EmbeddingsQueryGalleryDataset
  • update docs
  • QG and QGL datasets for both: embeddings and images

@AlekseySh AlekseySh self-assigned this Apr 19, 2024
@AlekseySh AlekseySh linked an issue Apr 19, 2024 that may be closed by this pull request
@AlekseySh AlekseySh requested a review from DaloroAT April 19, 2024 08:02
@AlekseySh AlekseySh merged commit 9a1305e into main Apr 20, 2024
7 checks passed
@AlekseySh AlekseySh deleted the refactor_datasets branch April 21, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[EPIC] Release OML 3.0
2 participants