Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MetricValCallbackDDP and samples_in_getitem #560

Merged
merged 3 commits into from
May 12, 2024
Merged

Remove MetricValCallbackDDP and samples_in_getitem #560

merged 3 commits into from
May 12, 2024

Conversation

AlekseySh
Copy link
Contributor

@AlekseySh AlekseySh commented May 12, 2024 •
edited
Loading

  • MetricValCallback is enough to handle DDP
  • samples_in_getitem is not used

@AlekseySh AlekseySh self-assigned this May 12, 2024
@AlekseySh AlekseySh linked an issue May 12, 2024 that may be closed by this pull request
[EPIC] Release OML 3.0 #522
Closed
@AlekseySh AlekseySh changed the base branch from main to oml_3.0_release May 12, 2024 14:10
@AlekseySh
Copy link
Contributor Author

I think, there is nothing to review, but just for your information, @DaloroAT

@AlekseySh AlekseySh merged commit cd9fc85 into oml_3.0_release May 12, 2024
1 check passed
@AlekseySh AlekseySh deleted the ddp_callback branch May 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlekseySh AlekseySh

Labels
rework
Projects
OML-planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EPIC] Release OML 3.0
1 participant
@AlekseySh