feat(slideshow) : #MAG-544 add description slide #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicedraillard
approved these changes
Feb 26, 2025
niko-amosse
approved these changes
Feb 26, 2025
| @@ -157,6 +157,10 @@ private Future<XMLSlideShow> createFreeLayoutSlideObjects(Board board, UserInfos | |||
| XSLFSlide titleApacheSlide = createTitleSlide(board, documents, i18nHelper); | |||
| ppt.createSlide().importContent(titleApacheSlide); | |||
|
|
|||
| //DESCRIPTION | |||
| XSLFSlide descriptionApacheSlide = createDescriptionSlide(board, i18nHelper); | |||
| ppt.createSlide().importContent(descriptionApacheSlide); | |||
There was a problem hiding this comment.
à voir après le rebase
lapeyronnie
approved these changes
Feb 27, 2025
FlorentMr
added a commit
that referenced
this pull request
Mar 5, 2025
* refactor(notify): migrate notification templates and configurations to view-src * feat(slide): add SlideController, SlideService, and DefaultSlideService classes * feat(export): add ExportController and DefaultExportService for PPTX export functionality * fix(export): update magnet number handling based on layout type in DefaultExportService * feat(slide): implement Slide classes and update slide object handling in DefaultExportService * feat(slide): enhance slide model with new SlideDescription and SlideTitle classes; update SlideText and SlideMedia constructors * feat(export): enhance export functionality by incorporating user information and refactoring slide creation logic * feat(export): update export functionality to return XMLSlideShow and improve slide creation logic * feat(slide): update SlideHelper and SlideText no double text and no corrupt * feat(slide): simplify SlideText createApacheSlide method by removing unnecessary comments and improving HTML parsing * feat(slide): add createImage method to SlideHelper and extend SlideProperties with file extension * feat(slide): refactor image stable * feat(export): add caption to resource data in DefaultExportService * feat(slide): update SlideMedia to include caption and version bump to 2.2-SNAPSHOT * feat(notify): remove notify_board.json configuration file * feat(slide) : #MAG-543 add first slide (#390) --------- Co-authored-by: Florent Mariotti <[email protected]> * feat(slideMedia): #MAG-548 slide media integration (#391) * feat(media): add audio icon SVG and enhance SlideMedia with media type detection feat(export): enhance media handling by copying media parts and relationships during slide export media audio stable media based on content-type feat(slide): refactor media icon creation and positioning for improved layout video stable * feat(export): add CONTENTTYPE constant and refactor DefaultExportService to use it * feat(export): refactor DefaultExportService to use constants for document fields * feat(slideshow): add standard icon and video dimensions as constants * refactor(export): remove debug print statements from ExportController * refactor(export): remove unused imports from ExportController * feat(slideshow) : #MAG-545 add sections slides (#392) --------- Co-authored-by: Florent Mariotti <[email protected]> * feat(slideshow) : #MAG-544 add description slide (#393) Co-authored-by: Florent Mariotti <[email protected]> * fix(slide) : #MAG-545 fix description and title flow (#394) --------- Co-authored-by: Florent Mariotti <[email protected]> * feat(slides) : #MAG-547 add board slides (#395) --------- Co-authored-by: Thomas Sevagen <[email protected]> Co-authored-by: Florent Mariotti <[email protected]> * feat(slides) : #MAG-546 add link slides (#396) Co-authored-by: Florent Mariotti <[email protected]> * feat(slides) : #MAG-551 add file slides (#397) --------- Co-authored-by: Florent Mariotti <[email protected]> * feat(slides) : add notes to link, board and media slides * feat(slides) : #MAG-554 add archive with slideshow and its documents (#398) Co-authored-by: Florent Mariotti <[email protected]> * feat(slides) : #MAG-555 add front modal and button for export (#399) * feat(slides) : #MAG-555 add front modal and button for export --------- Co-authored-by: Florent Mariotti <[email protected]> * Mag 212fixes (#400) --------- Co-authored-by: Florent Mariotti <[email protected]> --------- Co-authored-by: Florent Mariotti <[email protected]> Co-authored-by: Florent Mariotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add description slide just after the title slide, with a "Description" title and the description text.
Checklist tests
Issue ticket number and link
MAG-544
Checklist before requesting a review (magic string, indentation, comment/documentation...)