Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slide) : #MAG-545 fix description and title flow #394

Merged
merged 3 commits into from
Feb 28, 2025
Merged

fix(slide) : #MAG-545 fix description and title flow #394

merged 3 commits into from
Feb 28, 2025

Conversation

FlorentMr
Copy link
Contributor

@FlorentMr FlorentMr commented Feb 28, 2025 •
edited
Loading

Describe your changes

Checklist tests

Issue ticket number and link

Checklist before requesting a review (magic string, indentation, comment/documentation...)

  • I have detailed the tests to do in my feature/fix in order to prevent consequents regressions (must specify in Checklist tests)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (API Doc etc...) - (must specify in Description for target version)
  • If it is a consequent feature, I have added thorough tests.
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to this project (must specify in Description)

@FlorentMr FlorentMr merged commit f29201d into MAG-212 Feb 28, 2025
2 checks passed
@FlorentMr FlorentMr deleted the MAG-545flow branch February 28, 2025 10:30
FlorentMr added a commit that referenced this pull request Mar 5, 2025
@ThomasSevagen @FlorentMr
Mag 212 (#388)
17c1f6e 
* refactor(notify): migrate notification templates and configurations to view-src

* feat(slide): add SlideController, SlideService, and DefaultSlideService classes

* feat(export): add ExportController and DefaultExportService for PPTX export functionality

* fix(export): update magnet number handling based on layout type in DefaultExportService

* feat(slide): implement Slide classes and update slide object handling in DefaultExportService

* feat(slide): enhance slide model with new SlideDescription and SlideTitle classes; update SlideText and SlideMedia constructors

* feat(export): enhance export functionality by incorporating user information and refactoring slide creation logic

* feat(export): update export functionality to return XMLSlideShow and improve slide creation logic

* feat(slide): update SlideHelper and SlideText no double text and no corrupt

* feat(slide): simplify SlideText createApacheSlide method by removing unnecessary comments and improving HTML parsing

* feat(slide): add createImage method to SlideHelper and extend SlideProperties with file extension

* feat(slide): refactor image stable

* feat(export): add caption to resource data in DefaultExportService

* feat(slide): update SlideMedia to include caption and version bump to 2.2-SNAPSHOT

* feat(notify): remove notify_board.json configuration file

* feat(slide) : #MAG-543 add first slide (#390)

---------

Co-authored-by: Florent Mariotti <[email protected]>

* feat(slideMedia): #MAG-548 slide media integration (#391)

* feat(media): add audio icon SVG and enhance SlideMedia with media type detection

feat(export): enhance media handling by copying media parts and relationships during slide export

media audio stable

media based on content-type

feat(slide): refactor media icon creation and positioning for improved layout

video stable

* feat(export): add CONTENTTYPE constant and refactor DefaultExportService to use it

* feat(export): refactor DefaultExportService to use constants for document fields

* feat(slideshow): add standard icon and video dimensions as constants

* refactor(export): remove debug print statements from ExportController

* refactor(export): remove unused imports from ExportController

* feat(slideshow) : #MAG-545 add sections slides (#392)

---------

Co-authored-by: Florent Mariotti <[email protected]>

* feat(slideshow) : #MAG-544 add description slide (#393)

Co-authored-by: Florent Mariotti <[email protected]>

* fix(slide) : #MAG-545 fix description and title flow (#394)

---------

Co-authored-by: Florent Mariotti <[email protected]>

* feat(slides) : #MAG-547 add board slides (#395)

---------

Co-authored-by: Thomas Sevagen <[email protected]>
Co-authored-by: Florent Mariotti <[email protected]>

* feat(slides) : #MAG-546 add link slides (#396)

Co-authored-by: Florent Mariotti <[email protected]>

* feat(slides) : #MAG-551 add file slides (#397)

---------

Co-authored-by: Florent Mariotti <[email protected]>

* feat(slides) : add notes to link, board and media slides

* feat(slides) : #MAG-554 add archive with slideshow and its documents (#398)

Co-authored-by: Florent Mariotti <[email protected]>

* feat(slides) : #MAG-555 add front modal and button for export (#399)

* feat(slides) : #MAG-555 add front modal and button for export

---------

Co-authored-by: Florent Mariotti <[email protected]>

* Mag 212fixes (#400)

---------

Co-authored-by: Florent Mariotti <[email protected]>

---------

Co-authored-by: Florent Mariotti <[email protected]>
Co-authored-by: Florent Mariotti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niko-amosse niko-amosse niko-amosse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentMr @niko-amosse