Enhancement factor based on penetration theory for a pseudo-first order reaction #10
Conversation
flbrandao
force-pushed
the
ffn/penetration_pseudofirst
branch
from
106eb10 to
ff6f557
Compare
flbrandao
force-pushed
the
ffn/penetration_pseudofirst
branch
from
f727f2c to
937b485
Compare
| volScalarField arg = Foam::min(Ha, 15.0); | ||
| // | ||
|
|
||
| E_ = (1.0 + (pi/(8.0 * Foam::pow(Ha,2)))) * Foam::erf(Ha * Foam::pow(4.0/pi,0.5)); |
There was a problem hiding this comment.
Make sure to use spaces before and after operators like /, as well as after commas, to maintain readability. Also please use 2.0 instead of 2 to ensure everything is cast as a double, not an int.
|
|
||
| D1_(dimArea/dimTime/dimTemperature, massTransferModelCoeffs_.lookup<scalar>("Dl1")), | ||
| D2_(dimArea/dimTime, massTransferModelCoeffs_.lookup<scalar>("Dl2")), | ||
| tStart_(massTransferModelCoeffs_.lookupOrDefault<scalar>("tStart", 0.0)) |
There was a problem hiding this comment.
we should probably move the start time logic into the enhancementModel base class at some point, since we are duplicating the code in every new model
There was a problem hiding this comment.
Agree, but let's merge all models first. Then I create another request to modify that
| // this is to avoid that Foam::exp blows up due to very high values | ||
| volScalarField arg = Foam::min(Ha, 15.0); | ||
| // |
There was a problem hiding this comment.
these lines are indented with a tab instead of spaces and it is messing up the format. please use 8 spaces
| Description | ||
| Enhancement factor according to the penetration model | ||
| where E = Ha[{1 + pi/8*Ha^2}*erf{sqrt(4*Ha^2/pi)} + exp(4*Ha^2/pi)/2*Ha]. | ||
| Model more appropriate for 3 < Ha < E_inf; |
There was a problem hiding this comment.
i would add a note here that the actual value of Ha is capped at 15 so the exponential doesn't blow up
The enhancement factor based on the penetration theory for a pseudo 1st order reaction us added in this PR. The equation is given in:
[1] Putta, K. R., Tobiesen, F. A., Svendsen, H. F., & Knuutila, H. K. (2017).
Applicability of enhancement factor models for CO2 absorption into aqueous MEA solutions.
Applied Energy, 206, 765-783.
[2] Danckwerts PV. Gas-liquid reactions. McGraw-Hill; 1970.