[DAPS-1578] Device Auth Flow

.github/workflows/build-docs.yml

@@ -40,7 +40,7 @@ jobs:
                   ./scripts/generate_datafed.sh
             - name: Install documentation build dependencies
               run: |
-                  sudo ./scripts/install_docs_dependencies.sh
+                  sudo ./external/DataFedDependencies/scripts/install_docs_dependencies.sh
             - name: Build documentation
               run: |
                   cmake -S. -B build -DBUILD_AUTHZ=OFF -DBUILD_CORE_SERVER=OFF -DBUILD_COMMON=OFF -DBUILD_DOCS=ON -DBUILD_FOXX=OFF -DBUILD_REPO_SERVER=OFF -DBUILD_PYTHON_CLIENT=ON -DBUILD_TESTS=OFF -DBUILD_WEB_SERVER=OFF -DENABLE_UNIT_TESTS=OFF

.github/workflows/javascript-format.yml

@@ -8,26 +8,48 @@ jobs:
             # Step 1: Checkout the repository
             - name: Checkout Code
               uses: actions/checkout@v4
+              with:
+                  token: ${{ secrets.GITHUB_TOKEN }}
+                  ref: ${{ github.head_ref || github.ref }}
 
             # Step 2: Set up Node.js environment
             - name: Set up Node.js
               uses: actions/setup-node@v4
               with:
-                  node-version: "18" # Specify your Node.js version
+                  node-version: "18"
 
-            # Step 3: Install Prettier and ESLint globally
+            # Step 3: Install Prettier
             - name: Install Prettier
-              run: |
-                  npm install -g prettier
+              run: npm install -g prettier
 
             # Step 4: Run Prettier to format code
-            - name: Run prettier
+            - name: Format JavaScript files
               run: |
+                  echo "Auto-formatting JavaScript files..."
                   prettier "**/*.js" --write
-                  git diff
-                  git reset --hard
-                  prettier --check "**/*.js"
+                  echo "Formatting complete"
+
+            # Step 5: Check for changes and commit if needed
+            - name: Commit changes
+              run: |
+                  # Get the original commit author info
+                  AUTHOR_NAME=$(git log -1 --pretty=format:'%an')
+                  AUTHOR_EMAIL=$(git log -1 --pretty=format:'%ae')
+
+                  # Use original author for the formatting commit
+                  git config --local user.email "$AUTHOR_EMAIL"
+                  git config --local user.name "$AUTHOR_NAME"
 
-            # Step 5: Report status
-            - name: Complete
-              run: echo "Formatting completed successfully!"
+                  # Check if there are any changes
+                  if [[ -n $(git status -s) ]]; then
+                      echo "Formatting changes detected, creating commit..."
+                      echo "Committing as: $AUTHOR_NAME <$AUTHOR_EMAIL>"
+                      git add -A
+                      git commit -m "chore: Auto-format JavaScript files with Prettier"
+
+                      # Push changes
+                      git push
+                      echo "Changes committed and pushed"
+                  else
+                      echo "No formatting changes needed"
+                  fi

.github/workflows/shell-format.yml

@@ -0,0 +1,57 @@
+name: Shell Format Check
+
+on:
+    push:
+        paths:
+            - "**.sh"
+    pull_request:
+        paths:
+            - "**.sh"
+
+jobs:
+    shfmt:
+        runs-on: ubuntu-latest
+
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@v4
+              with:
+                  token: ${{ secrets.GITHUB_TOKEN }}
+                  ref: ${{ github.head_ref || github.ref }}
+
+            - name: Install shfmt
+              run: |
+                  sudo apt-get update
+                  sudo apt-get install -y shfmt
+
+            - name: Format shell scripts
+              run: |
+                  echo "Auto-formatting shell scripts..."
+                  # Run in check mode: if reformatting would be needed, it will fail
+                  # Use indentation space of 2 spaces
+                  shfmt -i 2 -w .
+                  echo "Formatting complete"
+
+            - name: Commit changes
+              run: |
+                  # Get the original commit author info
+                  AUTHOR_NAME=$(git log -1 --pretty=format:'%an')
+                  AUTHOR_EMAIL=$(git log -1 --pretty=format:'%ae')
+
+                  # Use original author for the formatting commit
+                  git config --local user.email "$AUTHOR_EMAIL"
+                  git config --local user.name "$AUTHOR_NAME"
+
+                  # Check if there are any changes
+                  if [[ -n $(git status -s) ]]; then
+                      echo "Formatting changes detected, creating commit..."
+                      echo "Committing as: $AUTHOR_NAME <$AUTHOR_EMAIL>"
+                      git add -A
+                      git commit -m "chore: Auto-format shell scripts with shfmt"
+
+                      # Push changes
+                      git push
+                      echo "Changes committed and pushed"
+                  else
+                      echo "No formatting changes needed"
+                  fi

.github/workflows/unit-tests.yml

@@ -2,31 +2,24 @@ name: Unit-Testing
 on: push
 jobs:
     unit-test:
-        runs-on: ubuntu-24.04
+        runs-on: ubuntu-latest
+        container: debian:bookworm
         if: ${{ always() }}
         steps:
-            - uses: actions/checkout@v4
-            - name: Update ubuntu
-              run: sudo apt-get update
-            - name: Install software-properties-common
-              run: sudo apt install software-properties-common
-            - name: Add deadsnakes apt repository
-              run: sudo add-apt-repository ppa:deadsnakes/ppa
-            - name: Update to bring in deadsnakes packages
-              run: sudo apt update
-            - name: Install Python 3.9
-              run: sudo apt install python3.9 python3.9-dev python3.9-venv python3.9-distutils
-            - name: Ensure pip is installed
-              run: python3.9 -m ensurepip
+            - uses: actions/checkout@v2
+            - name: Update debian
+              run: apt update
             - name: Install dependencies
+              with:
+                  submodules: recursive
+                  fetch-depth: 0
               run: |
                   ./scripts/generate_datafed.sh
-                  sudo ./scripts/install_core_dependencies.sh
-                  ./scripts/generate_datafed.sh
+                  ./external/DataFedDependencies/scripts/install_core_dependencies.sh
             - name: Build
               run: |
-                  cmake -S. -B build -DCMAKE_BUILD_TYPE=Debug -DBUILD_WEB_SERVER=OFF
-                  cmake --build build -j4
+                  /opt/datafed/dependencies/bin/cmake -S. -B build -DCMAKE_BUILD_TYPE=Debug -DBUILD_WEB_SERVER=OFF
+                  /opt/datafed/dependencies/bin/cmake --build build -j4
             - name: Run tests
               run: |
-                  cmake --build build --target test
+                  /opt/datafed/dependencies/bin/cmake --build build --target test

.github/workflows/yaml-format.yml

@@ -0,0 +1,33 @@
+name: Yaml Formatter
+on: push
+jobs:
+    format-yaml:
+        runs-on: ubuntu-latest
+
+        steps:
+            # Step 1: Checkout the repository
+            - name: Checkout Code
+              uses: actions/checkout@v4
+
+            # Step 2: Set up Node.js environment
+            - name: Set up Node.js
+              uses: actions/setup-node@v4
+              with:
+                  node-version: "18" # Specify your Node.js version
+
+            # Step 3: Install Prettier and ESLint globally
+            - name: Install Prettier
+              run: |
+                  npm install -g prettier
+
+            # Step 4: Run Prettier to format code
+            - name: Run prettier
+              run: |
+                  prettier "**/*.yml" --write
+                  git diff
+                  git reset --hard
+                  prettier --check "**/*.yml"
+
+            # Step 5: Report status
+            - name: Complete
+              run: echo "Formatting completed successfully!"

.gitignore

@@ -53,7 +53,8 @@ scripts/admin_datafed_backup.sh
 scripts/admin_refresh_certs.sh
 scripts/globus/__pycache__
 services/
-tmp/
+tests/mock_core/Version.hpp
+tmp
 web/SDMS.proto
 web/SDMS_Anon.proto
 web/SDMS_Auth.proto
@@ -65,6 +66,8 @@ web/package-lock.json
 web/static/datafed-core-key.pub
 *.swp
 *.swo
+*.tar.gz
+*.tgz
 
 # for web tests
 tests/end-to-end/web-UI/node_modules/
@@ -76,3 +79,10 @@ tests/end-to-end/web-UI/tests-examples
 tests/end-to-end/web-UI/.auth
 tests/end-to-end/web-UI/.env
 tests/end-to-end/web-UI/auth.setup.js
+
+# For Cargo
+target/
+out
+
+#Ignore vscode AI rules
+.github\instructions\codacy.instructions.md

.gitlab-ci.yml

@@ -18,6 +18,7 @@ include:
     - local: .gitlab/stage_pipeline_serialize.yml
     - local: .gitlab/infrastructure.yml
     - local: .gitlab/stage_clear_cache.yml
+    - local: .gitlab/stage_base_image_check.yml
     - local: .gitlab/stage_build_base.yml
     - local: .gitlab/stage_provision_client.yml
     - local: .gitlab/stage_image_check.yml
@@ -32,6 +33,7 @@ stages:
     - trigger-infrastructure
     - signal
     - clear-docker-cache
+    - base-image-check
     - build-base
     - provision-client
     - image-check
@@ -56,3 +58,4 @@ variables:
     REGISTRY: "camden.ornl.gov"
     DATAFED_DEPENDENCIES_INSTALL_PATH: "/shared/install"
     DOCKER_TLS_CERTDIR: "" # Required for running docker in docker
+    GIT_SUBMODULE_STRATEGY: recursive

.gitlab/build/build_core_image.yml

@@ -1,53 +1,53 @@
 ---
 stages:
-  - build
+    - build
 
 include:
-  - local: .gitlab/common.yml
+    - local: .gitlab/common.yml
 
 build-core:
-  extends: .docker_build_script
-  stage: build
-  variables:
-    PROJECT: "datafed"
-    COMPONENT: "core"
-    GIT_STRATEGY: clone
-    DOCKER_FILE_PATH: "core/docker/Dockerfile"
-    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
-    BUILD_INTERMEDIATE: "FALSE"
-  tags:
-    - ci-datafed-core
-    - docker
-  rules:
-    - changes:
-        - docker/**/*
-        - scripts/**/*
-        - core/**/*
-        - common/**/*
-        - CMakeLists.txt
-        - cmake/**/*
-        - .gitlab-ci.yml
-      when: on_success
+    extends: .docker_build_script
+    stage: build
+    variables:
+        PROJECT: "datafed"
+        COMPONENT: "core"
+        GIT_STRATEGY: clone
+        DOCKER_FILE_PATH: "core/docker/Dockerfile"
+        DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
+        BUILD_INTERMEDIATE: "FALSE"
+    tags:
+        - ci-datafed-core
+        - docker
+    rules:
+        - changes:
+              - docker/**/*
+              - scripts/**/*
+              - core/**/*
+              - common/**/*
+              - CMakeLists.txt
+              - cmake/**/*
+              - .gitlab-ci.yml
+          when: on_success
 
 retag-image:
-  extends: .docker_retag_image
-  stage: build
-  variables:
-    PROJECT: "datafed"
-    COMPONENT: "core"
-    GIT_STRATEGY: clone
-    DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
-    BUILD_INTERMEDIATE: "FALSE"
-  tags:
-    - docker
-  rules:
-    - changes:
-        - docker/**/*
-        - scripts/**/*
-        - core/**/*
-        - common/**/*
-        - CMakeLists.txt
-        - cmake/**/*
-        - .gitlab-ci.yml
-      when: never
-    - when: on_success
+    extends: .docker_retag_image
+    stage: build
+    variables:
+        PROJECT: "datafed"
+        COMPONENT: "core"
+        GIT_STRATEGY: clone
+        DATAFED_HARBOR_REGISTRY: "$REGISTRY" # needed by c_harbor_artifact_count
+        BUILD_INTERMEDIATE: "FALSE"
+    tags:
+        - docker
+    rules:
+        - changes:
+              - docker/**/*
+              - scripts/**/*
+              - core/**/*
+              - common/**/*
+              - CMakeLists.txt
+              - cmake/**/*
+              - .gitlab-ci.yml
+          when: never
+        - when: on_success