Added HashiCorp vault key provider #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekuaitk
force-pushed
the
feature/hashi-corp-vault
branch
from
628c82c to
3ee27b2
Compare
jekuaitk
force-pushed
the
feature/hashi-corp-vault
branch
from
06c10af to
b1e56f5
Compare
jekuaitk
force-pushed
the
feature/hashi-corp-vault
branch
from
7b0dc49 to
24df6fc
Compare
jekuaitk
force-pushed
the
feature/hashi-corp-vault
branch
from
24df6fc to
e78753a
Compare
rimi-itk
reviewed
Jan 17, 2025
src/Services/Psr16CacheAdapter.php
Outdated
There was a problem hiding this comment.
Can't we get this cache implementation from somewhere or somebody else? Do we really have to implement it ourselves? I have a feeling that we've done it before …
There was a problem hiding this comment.
As of now this is the only case where a PSR-16 implementation has been necessary. We could consider adding it to our Drupal PSR-6 cache module.
rimi-itk
approved these changes
Jan 17, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/2726
Description