-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend r.watershed test suite for differences between ram and seg versions #2482
base: main
Are you sure you want to change the base?
Conversation
…d seg version output for different inputs.
+ "\n" | ||
) | ||
|
||
self.assertTrue(all([all(p) for p in passes]), msg=msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test looks good. The only thing I would change is the number of reported failures. It's currently 1 from AssertionError
if any tests fail. It would be useful to report the number of individual failed tests (red circles) somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the test and the output, however the main issue is that the test fails and we can automatically run only tests which pass when everything is all right. Maybe there is a number of expected failures here to test against?
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
These tests are designed to give a comprehensive overview of matching output between the in-memory (ram) and segmentation library versions of
r.watershed
with different optional inputs. It relies on running the module with both versions and a random raster (n=10000) for the optional inputs. The min/max of the difference between output rasters are compared and tests pass if they do not exceed the following precisions/thresholds (open for suggestions):The current state of matches with optional input in columns:
I was not able to reproduce the mismatch in accumulation in the NC demo location reported by @HuidaeCho in #2222 with randomly assigned
flow
fractions (0-1), although other output does not match.