lib/vector: reading files with 'struct Map_info*' objects is technically not const #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marisn
requested changes
Mar 18, 2023
Co-authored-by: Māris Nartišs <[email protected]>
|
Re: even only reading file modifies the file object. I mentioned this issue in #2809 (comment) relating a similar problem reading raster files. |
marisn
approved these changes
Nov 20, 2023
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
…lly not const (OSGeo#2894) The qualifier is removed from the API and code using it. Co-authored-by: Māris Nartišs <[email protected]>
neteler
changed the title
neteler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing -Wdeprecated-non-prototype compiler warnings and adding missing prototypes in
lib/vector/Vlib/read.c, reveals API errors in lib functions passingstruct Map_info *as const. Reading vector files does in fact modify the Map_info struct, therefore theconstqualifier is not technically correct. Correcting this API in lib cascades through quite a few files, but functionally this doesn't change anything.Alternative to this may be to separate the file reading variables to a separate "read object", but that will modify the API in a very drastic way and would be anything but trivial.