-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.db.connect: Replace -o flag with the standard --overwrite #3214
Conversation
I'm sorry, but this shall not pass. You should not remove a flag in non-major release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HuidaeCho It make sense to me to add --overwrite
flag. On the other hand we cannot break backward compatibility in GRASS 8 releases. The -o
flag could be removed in GRASS 9. I suggest to add depreciation warning that -o
will be removed in GRASS 9.
This PR requires #3256. |
67a285d
to
ab14fac
Compare
ab14fac
to
5bbcb15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a test to prove that both -o
and --overwrite
work? Probably using gs.run_command(...)
(with flags="o"
and overwrite=True
) rather than the assert*()
functions which rely on grass.pygrass Module interface which performs checks on its own and does not support lib/gis/renamed_options
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I successfully tested:
v.db.connect map=voda_aoi table=VodniTok
ERROR: Use --overwrite to overwrite existing link for layer <1>
v.db.connect map=voda_aoi table=VodniTok --o
The table <VodniTok> is now part of vector map <voda_aoi> and may be
deleted or overwritten by GRASS modules
v.db.connect map=voda_aoi table=VodniTok --o
The table <VodniTok> is now part of vector map <voda_aoi> and may be
deleted or overwritten by GRASS modules
@HuidaeCho Please feel free to merge (you have more than zero approvals)... |
69ab709
to
1af485a
Compare
This PR fixes #3149 by using the standard
--overwrite
flag.